Skip to content

[DataQueryTool] Query stuck when CandID is NULL — add safeguard #9835 -fix #9836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 1 commit into from
Jun 11, 2025
Merged

[DataQueryTool] Query stuck when CandID is NULL — add safeguard #9835 -fix #9836

driusan merged 1 commit into from
Jun 11, 2025

Conversation

@kongtiaowang
Copy link
Contributor

@kongtiaowang kongtiaowang commented Jun 5, 2025

[DataQueryTool] Query stuck when CandID is NULL — add safeguard #9835

test:
Add a condition to check if CandID is NULL in any query. If any CandID is 0, it will cause the query to hang or behave unexpectedly
What did you expect to happen?
It should show "no results found"

Image

Image

@kongtiaowang kongtiaowang changed the base branch from main to 27.0-release June 5, 2025 14:33
@github-actions github-actions bot added Language: SQL PR or issue that update SQL code RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: statistics PR or issue related to statistics module Module: behavioural_qc PR or issue related behavioural_qc module Module: dashboard PR or issue related to dashboard module Module: genomic_browser PR or issue related to genomic_browser module Module: instruments PR or issue related to instruments module Module: schedule_module PR or issue related to the schedule_manager module Module: dataquery PR or issue related to (new) dataquery module labels Jun 5, 2025
@kongtiaowang kongtiaowang added the 27.0.0 - Bugs Bugs Found in LORIS 27 testing label Jun 5, 2025
@driusan driusan merged commit 3b2b55b into aces:27.0-release Jun 11, 2025
1 check passed
@driusan driusan mentioned this pull request Jun 11, 2025
Closed
@driusan
Copy link
Collaborator

driusan commented Jun 11, 2025

I merged this because it fixes some cases, but if the type of iterable is not an array that gets passed the query will still crash.

SKADE2303 pushed a commit to SKADE2303/Loris that referenced this pull request Jul 10, 2025
@kongtiaowang
[DataQueryTool] Query stuck when no candidates are returned (aces#9836)
90deb59 
Add a condition to check if CandID list is empty in any query.

Currently, this causes the query to crash.
jeffersoncasimir pushed a commit to jeffersoncasimir/Loris that referenced this pull request Aug 11, 2025
@kongtiaowang @jeffersoncasimir
[DataQueryTool] Query stuck when no candidates are returned (aces#9836)
f399164 
Add a condition to check if CandID list is empty in any query.

Currently, this causes the query to crash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@driusan driusan

Labels

27.0.0 - Bugs Bugs Found in LORIS 27 testing Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Language: SQL PR or issue that update SQL code Module: behavioural_qc PR or issue related behavioural_qc module Module: dashboard PR or issue related to dashboard module Module: dataquery PR or issue related to (new) dataquery module Module: genomic_browser PR or issue related to genomic_browser module Module: instruments PR or issue related to instruments module Module: schedule_module PR or issue related to the schedule_manager module Module: statistics PR or issue related to statistics module RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kongtiaowang @driusan