improve: Add ability to unwhitelist a route #66
Conversation
contracts/HubPool.sol
Outdated
| "setEnableRoute(address,uint256,bool)", | ||
| originToken, | ||
| destinationChainId, | ||
| (destinationToken != address(0)) // We assume that setting the destination token to 0x0 for any route |
There was a problem hiding this comment.
the other option would be to add a bool to the props and let the caller pass it in. either is ok I think but what you have here does make some implementations impossible (if the target chain actually uses destinationToken of 0x0, which should never happen)
There was a problem hiding this comment.
let's add a bool to the function call params then as the gas increase is not important for a function that shoudn't be called that frequently
There was a problem hiding this comment.
If we did it with a bool, we'd need additional branching at the top of this method.
I do think using 0x0 is a bit more subtle, but the implementation might be a little cleaner this way.
I think either way makes sense.
There was a problem hiding this comment.
i think additional branching is fine for functions where we are not as gas cost sensitive like this one
contracts/HubPool.sol
Outdated
| "setEnableRoute(address,uint256,bool)", | ||
| originToken, | ||
| destinationChainId, | ||
| (destinationToken != address(0)) // We assume that setting the destination token to 0x0 for any route |
There was a problem hiding this comment.
If we did it with a bool, we'd need additional branching at the top of this method.
I do think using 0x0 is a bit more subtle, but the implementation might be a little cleaner this way.
I think either way makes sense.
No description provided.