improve(spoke-pool): Slow relay execution should emit FillRelay event #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrice32
reviewed
Mar 7, 2022
Comment on lines
+629
to
+631
| // Note: Set repayment chain ID to 0 to indicate that there is no repayment to be made. The off-chain data | ||
| // worker can use repaymentChainId=0 as a signal to ignore such relays for refunds. | ||
| _emitFillRelay(relayHash, fillAmountPreFees, 0, relayerFeePct, relayData); |
Contributor
There was a problem hiding this comment.
I think not emitting this event was intentional. What benefit does this one provide over using the other event that's already being emitted?
mrice32
reviewed
Mar 7, 2022
| ) | ||
| ) | ||
| ) | ||
| .to.emit(spokePool, "ExecutedSlowRelayRoot") |
Contributor
There was a problem hiding this comment.
Why do we no longer check this event?
This was referenced Mar 9, 2022
This was referenced Apr 6, 2022
This was referenced May 3, 2022
Merged
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.