improve: Update ethereum package versions #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrice32
reviewed
Mar 7, 2022
Contributor
mrice32
left a comment
mrice32
left a comment
There was a problem hiding this comment.
Looks good! One comment on typechain
package.json
Outdated
| "@nomiclabs/hardhat-waffle": "^2.0.3", | ||
| "@typechain/ethers-v5": "^7.0.1", | ||
| "@typechain/hardhat": "^2.3.0", | ||
| "@typechain/hardhat": "^4.0.0", |
Contributor
There was a problem hiding this comment.
Should we update this in tandem with all the other typechain packages?
Member
Author
There was a problem hiding this comment.
Yeah I'll hold off for now
mrice32
requested changes
Mar 7, 2022
Contributor
mrice32
left a comment
mrice32
left a comment
There was a problem hiding this comment.
@nicholaspai I think you need to rerun yarn to regenerate yarn.lock from your last commit.
Member
Author
Great catch thanks |
This was referenced Mar 9, 2022
This was referenced Apr 6, 2022
This was referenced May 3, 2022
Merged
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two big features I'd like to take advantage of:
hardhatbase package performancehardhat-etherscan > 3.0.0allows you to specify multiple API keystypechaintype which produced a large diff, let me know if you want me to remove this part