build for release, including exporting artefacts and fixtures #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismaree
commented
Mar 7, 2022
| l2GatewayRouter = await createFake("L2GatewayRouter"); | ||
|
|
||
| arbitrumSpokePool = await ( | ||
| await getContractFactory("Arbitrum_SpokePool", { signer: owner }) |
Member
Author
There was a problem hiding this comment.
this syntax was actually redundant all over the place and can be removed without impacting anything.
chrismaree
commented
Mar 7, 2022
| } | ||
|
|
||
| // Fetch the artifact from the publish package's artifacts directory. | ||
| function getLocalArtifact(contractName: string) { |
Member
Author
There was a problem hiding this comment.
this method enables the util to find artefacts when run from node modules.
chrismaree
changed the title
chrismaree
requested review from
mrice32 and
nicholaspai
and removed request for
mrice32
mrice32
approved these changes
Mar 7, 2022
| // from node modules which breaks using the hardhat getContractFactory function. | ||
| try { | ||
| const localArtifact = getLocalArtifact(name); | ||
| return new ContractFactory(localArtifact.abi, localArtifact.bytecode, signerOrFactoryOptions as Signer); |
Contributor
There was a problem hiding this comment.
So basically this won't work with libraries?
| // Fetch the artifact from the publish package's artifacts directory. | ||
| function getLocalArtifact(contractName: string) { | ||
| const artifactsPath = `${__dirname}/../../artifacts/contracts`; | ||
| return findArtifactFromPath(contractName, artifactsPath); |
Contributor
There was a problem hiding this comment.
This might be a bit inefficient, but we could always add caching later to speed things up.
This was referenced Mar 9, 2022
This was referenced Apr 6, 2022
This was referenced May 3, 2022
Merged
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.