chore: Update GbtsDataStorage to ACTS coding standard#4956
Merged
kodiakhq[bot] merged 12 commits intoacts-project:mainfrom Jan 16, 2026
Merged
chore: Update GbtsDataStorage to ACTS coding standard#4956kodiakhq[bot] merged 12 commits intoacts-project:mainfrom
GbtsDataStorage to ACTS coding standard#4956kodiakhq[bot] merged 12 commits intoacts-project:mainfrom
Conversation
fixed merge conflicts based on changes to refactoring PR that where added
Contributor
Author
|
just to note, i did all of the changes to fixed size variables for int, unsigned int, char, short ect at the end of all my code inspections so they will be fixed at the end (unless it would make more sense do that now) |
Contributor
andiwand
reviewed
Jan 14, 2026
andiwand
previously approved these changes
Jan 15, 2026
Contributor
|
/ci-bridge-run |
Contributor
|
/ci-bridge-run |
Contributor
|
/ci-bridge-run |
Contributor
|
/ci-bridge-run |
|
andiwand
approved these changes
Jan 16, 2026
Collaborator
acts-project-service
added
the
Breaks Athena build
JustusRudolph
pushed a commit
to JustusRudolph/acts
that referenced
this pull request
Feb 23, 2026
…#4956) This is the second in a series of PR's that aim to bring GBTS up to date with ACTS coding standards. This PR focuses on the comments made about the `GbtsDataStorage` files and aims to update them accordingly, this includes things like changing to appropriate containers, re structuring classes and changing to fixed size variables. Other related changes are also made to the files affected by the `GbtsDataStorage` changes.
JustusRudolph
pushed a commit
to JustusRudolph/acts
that referenced
this pull request
Feb 24, 2026
…#4956) This is the second in a series of PR's that aim to bring GBTS up to date with ACTS coding standards. This PR focuses on the comments made about the `GbtsDataStorage` files and aims to update them accordingly, this includes things like changing to appropriate containers, re structuring classes and changing to fixed size variables. Other related changes are also made to the files affected by the `GbtsDataStorage` changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second in a series of PR's that aim to bring GBTS up to date with ACTS coding standards.
This PR focuses on the comments made about the
GbtsDataStoragefiles and aims to update them accordingly, this includes things like changing to appropriate containers, re structuring classes and changing to fixed size variables. Other related changes are also made to the files affected by theGbtsDataStoragechanges.--- END COMMIT MESSAGE ---
@timadye @andiwand