fix: Track container resize dynamic columns if the column is created after tracks have been made#5463
Merged
Merged
Conversation
github-actions
Bot
added
Component - Core
andiwand
previously approved these changes
May 18, 2026
andiwand
left a comment
andiwand
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 thanks @junggjo9 !
I would still wait for @paulgessinger to have a look before getting this in
Contributor
added 3 commits
May 19, 2026 08:54
…racks have been already appended
andiwand
reviewed
May 19, 2026
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
junggjo9
commented
May 19, 2026
Hupps public Make the compiler hapyp
paulgessinger
previously approved these changes
May 20, 2026
paulgessinger
left a comment
paulgessinger
left a comment
Member
There was a problem hiding this comment.
Fine by me. The only question I have is if we could locate this behavior in the front end somehow so that we could get it consistently also for back ends like and xAOD? (even if the latter isn't really used anymore)
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
Contributor
Author
|
I am not really sure how we could do this. I've encountered this issue when I tried to decorate the track returned from the global chi2 fitter (https://gitlab.cern.ch/atlas/athena/-/merge_requests/88064) |
andiwand
approved these changes
May 20, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--- END COMMIT MESSAGE ---
Tagging @andiwand, @paulgessinger