Skip to content

Bugfix/event listener callback issue #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartoszglow merged 15 commits into from
Oct 7, 2020
Merged

Bugfix/event listener callback issue #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ef06e25
addEventListener process / push implementation
bartoszglow Sep 21, 2020
b59ec5f
unit tests: check for arguments in listener callbacks
bartoszglow Sep 21, 2020
348a74f
linter errors fixed
bartoszglow Sep 22, 2020
5ef6a51
additional unit tests for data layer initialization order
bartoszglow Sep 23, 2020
d9aaba2
linter errors, extended examples
bartoszglow Sep 24, 2020
3a25102
proper data layer initialization in unit tests
bartoszglow Sep 24, 2020
4fcaecd
unit tests improvements
bartoszglow Sep 28, 2020
d2457c6
unit test for DL initialization and event listeners with different sc…
bartoszglow Sep 29, 2020
d83d8ea
extended limit time for performance tests
bartoszglow Oct 1, 2020
3dc1265
Push items from anonymous functions for later initialization
bartoszglow Oct 5, 2020
a698367
[Regression] getState method returns no data in event callback
jckautzmann Oct 6, 2020
aac61dc
[Regression] getState method returns no data in event callback
jckautzmann Oct 6, 2020
ec06c95
Tests enabled, _preLoadedItems as a slice of _dataLayer
bartoszglow Oct 7, 2020
1813fe8
unit tests for nested anonymous functions
bartoszglow Oct 7, 2020
b2e6244
[Regression] getState method returns no data in event callback
jckautzmann Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<title>Adobe Data Layer | Examples</title>
<script>adobeDataLayer = [];</script>
<script src="../dist/adobe-client-data-layer.min.js" async></script>
<script src="js/datalayer.mocks.1.js" defer></script>
<script src="js/datalayer.mocks.1.js"></script>
</head>
<body>
<h1>Adobe Client Data Layer | Examples</h1>
Expand Down
52 changes: 52 additions & 0 deletions examples/js/datalayer.mocks.2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
/*
Copyright 2019 Adobe. All rights reserved.
This file is licensed to you under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. You may obtain a copy
of the License at http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software distributed under
the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS
OF ANY KIND, either express or implied. See the License for the specific language
governing permissions and limitations under the License.
*/
/* global console, window, dataLayer, CustomEvent */
(function() {
'use strict';

/* eslint no-console: "off" */
/* eslint no-unused-vars: "off" */

// Test case: scope = past -> console output should be: event1, event2

window.adobeDataLayer = window.adobeDataLayer || [];

var myHandler = function(event) {
console.log(event.event);
};

adobeDataLayer.push({
event: "event1"
});

adobeDataLayer.push(function(dl) {
dl.push({
event: "event2"
});

dl.addEventListener(
"adobeDataLayer:event",
myHandler,
{"scope": "past"}
);

dl.push({
event: "event3"
});

});

adobeDataLayer.push({
event: "event4"
});

})();
52 changes: 52 additions & 0 deletions examples/js/datalayer.mocks.3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
/*
Copyright 2019 Adobe. All rights reserved.
This file is licensed to you under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. You may obtain a copy
of the License at http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software distributed under
the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS
OF ANY KIND, either express or implied. See the License for the specific language
governing permissions and limitations under the License.
*/
/* global console, window, dataLayer, CustomEvent */
(function() {
'use strict';

/* eslint no-console: "off" */
/* eslint no-unused-vars: "off" */

// Test case: scope = future -> console output should be: event3, event4

window.adobeDataLayer = window.adobeDataLayer || [];

var myHandler = function(event) {
console.log(event.event);
};

adobeDataLayer.push({
event: "event1"
});

adobeDataLayer.push(function(dl) {
dl.push({
event: "event2"
});

dl.addEventListener(
"adobeDataLayer:event",
myHandler,
{"scope": "future"}
);

dl.push({
event: "event3"
});

});

adobeDataLayer.push({
event: "event4"
});

})();
Loading