-
Notifications
You must be signed in to change notification settings - Fork 79
CIF-2107 - Add Magento Storefront Events SDK #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
============================================
+ Coverage 87.24% 87.90% +0.66%
- Complexity 1333 1363 +30
============================================
Files 238 249 +11
Lines 6219 6410 +191
Branches 927 961 +34
============================================
+ Hits 5426 5635 +209
+ Misses 597 580 -17
+ Partials 196 195 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This was referenced Jun 2, 2021
10 tasks
laurentiumagureanu
approved these changes
Jun 8, 2021
mhaack
approved these changes
Jun 8, 2021
10 tasks
* CIF-2120: Add JSON Product data to DOM * CIF-2120: Refactor storefront context packages * CIF-2120: format code * CIF-2120: Rename clasees for better semantics * CIF-2120: Add unit test * CIF-2120: Fix JS formatting * CIF-2120: Refactor ProductStorefrontContextImpl * CIF-2120: collect storefront data onDocumentReady * CIF-2120: Fix formatting
* CIF-2120: Add JSON Product data to DOM * CIF-2120: Refactor storefront context packages * CIF-2120: format code * CIF-2120: Rename clasees for better semantics * CIF-2120: Add unit test * CIF-2120: Fix JS formatting * CIF-2118: Add StorefrontContext to productList * CIF-2120: Refactor ProductStorefrontContextImpl * CIF-2118: Add category storefront context to dataLayer * CIF-2118: Remove unnecessary function calls * CIF-2120: collect storefront data onDocumentReady * CIF-2120: Fix formatting * CIF-2118: collect storefront data onDocumentReady
* CIF-2120: Add JSON Product data to DOM * CIF-2120: Refactor storefront context packages * CIF-2120: format code * CIF-2120: Rename clasees for better semantics * CIF-2120: Add unit test * CIF-2120: Fix JS formatting * CIF-2120: Refactor ProductStorefrontContextImpl * CIF-2121: Add SearchInput Storefront context * CIF-2120: collect storefront data onDocumentReady * CIF-2120: Fix formatting * CIF-2121: collect storefront data onDocumentReady * CIF-2121: Fix SearchInput storefront context * CIF-2121: fix code styling
* CIF-2124 - Add customUrl and referrer Storefront Events * CIF-2124 - Add pageView Storefront Events * CIF-2124 - Add unit tests
* CIF-2122 - Add storefront events to UserContext * CIF-2122 - Add unit tests
* CIF-2119: Add storefront events to checkout * CIF-2119: Add unit tests for checkout events * CIF-2119: Add unit tests for checkout events * CIF-2119: improve unit tests
* CIF-2123 - Add storefront events to Minicart * CIF-2123 - Add storefront events to Minicart * CIF-2123 - Add unit tests * CIF-2123 - Fix test failures Co-authored-by: Laurentiu Magureanu <magurean@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
core.cif.components.storefront-events.v1clientlib which embeds the@adobe/magento-storefront-events-sdknpm package and exposes it globally atwindow.magentoStorefrontEvents, so it can be used by both the server-side and client-side components.so do not merge yet.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: