-
Notifications
You must be signed in to change notification settings - Fork 79
CIF-2119: Add storefront events to checkout components #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## issue/CIF-2107 #589 +/- ##
====================================================
+ Coverage 87.44% 87.71% +0.26%
Complexity 1363 1363
====================================================
Files 249 249
Lines 6357 6374 +17
Branches 943 951 +8
====================================================
+ Hits 5559 5591 +32
+ Misses 603 588 -15
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| expect(getByRole('button')).not.toBeUndefined(); | ||
| await act(async () => fireEvent.click(getByRole('button'))); | ||
|
|
||
| expect(mse.context.setOrder).toHaveBeenCalledTimes(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it makes sense to check for the value the setOrder method was called with here.
* CIF-2107 - Add Magento Storefront Events SDK * CIF-2107 - Add Magento Storefront Events SDK * CIF-2107 - Fix AEM cloudready base image version * CIF-2107 - Add client-side foundation for Magento Storefront Events SDK * CIF-2120: Add StorefrontEvents to PDP (#582) * CIF-2120: Add JSON Product data to DOM * CIF-2120: Refactor storefront context packages * CIF-2120: format code * CIF-2120: Rename clasees for better semantics * CIF-2120: Add unit test * CIF-2120: Fix JS formatting * CIF-2120: Refactor ProductStorefrontContextImpl * CIF-2120: collect storefront data onDocumentReady * CIF-2120: Fix formatting * CIF-2118: Add StorefrontContext to productList (#583) * CIF-2120: Add JSON Product data to DOM * CIF-2120: Refactor storefront context packages * CIF-2120: format code * CIF-2120: Rename clasees for better semantics * CIF-2120: Add unit test * CIF-2120: Fix JS formatting * CIF-2118: Add StorefrontContext to productList * CIF-2120: Refactor ProductStorefrontContextImpl * CIF-2118: Add category storefront context to dataLayer * CIF-2118: Remove unnecessary function calls * CIF-2120: collect storefront data onDocumentReady * CIF-2120: Fix formatting * CIF-2118: collect storefront data onDocumentReady * CIF-2121: Add SearchInput Storefront context (#585) * CIF-2120: Add JSON Product data to DOM * CIF-2120: Refactor storefront context packages * CIF-2120: format code * CIF-2120: Rename clasees for better semantics * CIF-2120: Add unit test * CIF-2120: Fix JS formatting * CIF-2120: Refactor ProductStorefrontContextImpl * CIF-2121: Add SearchInput Storefront context * CIF-2120: collect storefront data onDocumentReady * CIF-2120: Fix formatting * CIF-2121: collect storefront data onDocumentReady * CIF-2121: Fix SearchInput storefront context * CIF-2121: fix code styling * CIF-2124 - Add page related storefront events (#592) * CIF-2124 - Add customUrl and referrer Storefront Events * CIF-2124 - Add pageView Storefront Events * CIF-2124 - Add unit tests * CIF-2122 - Add storefront events to UserContext (#581) * CIF-2122 - Add storefront events to UserContext * CIF-2122 - Add unit tests * CIF-2119: Add storefront events to checkout components (#589) * CIF-2119: Add storefront events to checkout * CIF-2119: Add unit tests for checkout events * CIF-2119: Add unit tests for checkout events * CIF-2119: improve unit tests * CIF-2123 - Add storefront events to Minicart (#587) * CIF-2123 - Add storefront events to Minicart * CIF-2123 - Add storefront events to Minicart * CIF-2123 - Add unit tests * CIF-2123 - Fix test failures Co-authored-by: Laurentiu Magureanu <magurean@adobe.com> * CIF-2107: Revert UID removal Co-authored-by: Laurentiu Magureanu <magurean@adobe.com> Co-authored-by: Markus Haack <mhaack@adobe.com>
Description
Related Issue
CIF-2119
Motivation and Context
Required by the product recommendations engine
How Has This Been Tested?
Unit tests
Screenshots (if appropriate):
Types of changes
Checklist: