Skip to content

Conversation

@im-shiv
Copy link
Contributor

@im-shiv im-shiv commented Nov 21, 2023

Reverts #968

This reverts commit 6e24c4a.
@im-shiv im-shiv requested a review from barshat7 November 21, 2023 06:16
@im-shiv im-shiv requested a review from rismehta November 21, 2023 06:26
@codecov
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (559cd44) 80.29% compared to head (ef7de8e) 80.37%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1001      +/-   ##
============================================
+ Coverage     80.29%   80.37%   +0.08%     
- Complexity      729      733       +4     
============================================
  Files            89       90       +1     
  Lines          2045     2054       +9     
  Branches        271      271              
============================================
+ Hits           1642     1651       +9     
  Misses          251      251              
  Partials        152      152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@egmox
Copy link
Contributor

egmox commented Nov 22, 2023

Please rebase with dev. We have removed readonly from components not supporting it
ref: FORMS-10934

@im-shiv
Copy link
Contributor Author

im-shiv commented Mar 20, 2024

added it via #1131

@im-shiv im-shiv closed this Mar 20, 2024
@im-shiv im-shiv deleted the revert-968-rte-revert branch March 20, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants