Skip to content

Revert "Revert "Rich text support (#1077)"" #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 20, 2024
Merged

Revert "Revert "Rich text support (#1077)"" #1131

merged 4 commits into from
Mar 20, 2024

Conversation

@im-shiv
Copy link
Contributor

@im-shiv im-shiv commented Mar 19, 2024

Reverts #1129

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (a249f93) to head (0526472).

Additional details and impacted files 
@@            Coverage Diff            @@
##                dev    #1131   +/-   ##
=========================================
  Coverage     80.74%   80.74%           
  Complexity      771      771           
=========================================
  Files            91       91           
  Lines          2108     2108           
  Branches        285      285           
=========================================
  Hits           1702     1702           
  Misses          252      252           
  Partials        154      154

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 87 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

1 similar comment
@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

rismehta
rismehta reviewed Mar 19, 2024
View reviewed changes
bundles/af-core/src/test/resources/form/radiobutton/exporter-radiobutton-customized.json
"enumNames": [
"Item 1",
"Item 2"
"<p>Item 1</p>",
Copy link
Collaborator

@rismehta rismehta Mar 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case for use-case when the options are not rich text, in this case, json should not have

tag in it.

Copy link
Contributor Author

@im-shiv im-shiv Mar 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have existing test cases in place for enum names in checkbox group, dropdown, switch etc which doesn't have rich text in enum names.

rismehta
rismehta requested changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the spec and fix the spec json present in the test collateral as part of this PR

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 87 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Mar 19, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@im-shiv im-shiv requested a review from rismehta March 20, 2024 03:18
@rismehta rismehta merged commit da93d69 into dev Mar 20, 2024
@rismehta rismehta deleted the revert-1129-rte_revert branch March 20, 2024 10:54
@im-shiv im-shiv mentioned this pull request Mar 20, 2024
Closed
ravise5 pushed a commit that referenced this pull request Mar 26, 2024
@im-shiv @ravise5
Revert "Revert "Rich text support (#1077)"" (#1131)
ce5ea5e 
* Revert "Revert "Rich text support (#1077)" (#1129)"

This reverts commit a249f93.

* reverting enumNames spec change

* changes needed

* removing addon check not needed

---------

Co-authored-by: Shivam Agarwal <shivama@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rismehta rismehta Awaiting requested review from rismehta

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@im-shiv @adobe-bot @rismehta