Approval checkbox required by default #1322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1322 +/- ##
=========================================
Coverage 81.73% 81.73%
Complexity 853 853
=========================================
Files 97 97
Lines 2267 2267
Branches 305 305
=========================================
Hits 1853 1853
Misses 255 255
Partials 159 159 ☔ View full report in Codecov by Sentry. |
rismehta
requested changes
Jul 19, 2024
Collaborator
rismehta
left a comment
rismehta
left a comment
There was a problem hiding this comment.
Please add a runtime test case for the same, no PR's without test case.
barshat7
reviewed
Jul 19, 2024
| jcr:title="I agree to the terms & conditions" | ||
| sling:resourceType="core/fd/components/form/checkbox/v1/checkbox" | ||
| enabled="false" | ||
| required="true" |
Contributor
There was a problem hiding this comment.
Please add the changes in archetype proxy also
https://github.com/adobe/aem-project-archetype/blob/develop/src/main/archetype/ui.apps/src/main/content/jcr_root/apps/__appId__/components/adaptiveForm/termsandconditions/_cq_template.xml
github-actions
bot
force-pushed
the
tnc/add
branch
from
ba92011 to
25e9b2b
Compare
Contributor
Author
Added test case for the same! |
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
approved these changes
Jul 23, 2024
rismehta
requested changes
Jul 23, 2024
Collaborator
rismehta
left a comment
rismehta
left a comment
There was a problem hiding this comment.
You should make it required here, https://github.com/adobe/aem-core-forms-components/blob/master/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/termsandconditions/v1/termsandconditions/_cq_template.xml and also in the archetype
github-actions
bot
force-pushed
the
tnc/add
branch
from
e00f327 to
fe2e692
Compare
* updating eventsource while updating model value * Adding ui change event to update model value * Fixing package lock * Fixing text input code --------- Co-authored-by: vdua <vdua@adobe.com>
github-actions
bot
force-pushed
the
tnc/add
branch
from
e00f327 to
5e070ea
Compare
Contributor
Author
@rismehta I have added it in the file you mentioned, will create the seperate PR for archetype |
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
approved these changes
Jul 25, 2024
rismehta
added a commit
that referenced
this pull request
Jul 25, 2024
* Approval checkbox required by default * FORMS-15481 Adding ui change event to update model value (#1327) * updating eventsource while updating model value * Adding ui change event to update model value * Fixing package lock * Fixing text input code --------- Co-authored-by: vdua <vdua@adobe.com> --------- Co-authored-by: Pavitra Khatri <pavitrakhatri@Pavitras-MacBook-Pro.local> Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com> Co-authored-by: vdua <vdua@adobe.com>
rismehta
added a commit
that referenced
this pull request
Jul 25, 2024
* Approval checkbox required by default * FORMS-15481 Adding ui change event to update model value (#1327) * updating eventsource while updating model value * Adding ui change event to update model value * Fixing package lock * Fixing text input code --------- Co-authored-by: vdua <vdua@adobe.com> --------- Co-authored-by: Pavitra Khatri <pavitrakhatri@Pavitras-MacBook-Pro.local> Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com> Co-authored-by: vdua <vdua@adobe.com>
dmaurya929
pushed a commit
that referenced
this pull request
Aug 13, 2024
* Approval checkbox required by default * FORMS-15481 Adding ui change event to update model value (#1327) * updating eventsource while updating model value * Adding ui change event to update model value * Fixing package lock * Fixing text input code --------- Co-authored-by: vdua <vdua@adobe.com> --------- Co-authored-by: Pavitra Khatri <pavitrakhatri@Pavitras-MacBook-Pro.local> Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com> Co-authored-by: vdua <vdua@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: