FORMS-14419 Adding instances on repeatable element using loop throwing error #1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blility-fix # Conflicts: # ui.frontend/src/view/InstanceManager.js
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1332 +/- ##
=========================================
Coverage 81.73% 81.73%
Complexity 853 853
=========================================
Files 97 97
Lines 2267 2267
Branches 305 305
=========================================
Hits 1853 1853
Misses 255 255
Partials 159 159 ☔ View full report in Codecov by Sentry. |
sakshi-arora1
approved these changes
Jul 26, 2024
rismehta
requested changes
Jul 26, 2024
Collaborator
rismehta
left a comment
rismehta
left a comment
There was a problem hiding this comment.
Can we follow the latest ES6 syntax, let's not use var etc
rismehta
reviewed
Jul 26, 2024
...re/fd/components/form/checkboxgroup/v1/checkboxgroup/clientlibs/site/js/checkboxgroupview.js
Show resolved
Hide resolved
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
approved these changes
Aug 5, 2024
dmaurya929
added a commit
that referenced
this pull request
Aug 13, 2024
…g error (#1332) * Fix adding items in loop * Fix adding items in loop * FORMS-14419 Adding fix for complex layouts * FORMS-14419 add test * FORMS-14419 review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: