-
Notifications
You must be signed in to change notification settings - Fork 64
FORMS-14419 Adding instances on repeatable element using loop throwing error #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2ca34ee
Fix adding items in loop
dmaurya929 92366c5
Fix adding items in loop
dmaurya929 0d6ad56
FORMS-14419 Adding fix for complex layouts
dmaurya929 7950e4b
Merge remote-tracking branch 'origin/repeatablility-fix' into repeata…
dmaurya929 77dee5d
Merge branch 'dev' of https://github.com/adobe/aem-core-forms-compone…
dmaurya929 787b747
FORMS-14419 add test
dmaurya929 fe38983
FORMS-14419 review comment
dmaurya929 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
23 changes: 23 additions & 0 deletions
23
...ponents-it/samples/panelcontainer/repeatability-tests/add-instances-via-loop/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:dam="http://www.day.com/dam/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" xmlns:xmp="http://ns.adobe.com/xap/1.0/" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:fd="http://www.adobe.com/aemfd/fd/1.0" | ||
| jcr:primaryType="dam:Asset"> | ||
| <jcr:content | ||
| cq:conf="\0" | ||
| jcr:lastModified="{Date}2024-07-28T15:11:24.872+05:30" | ||
| jcr:primaryType="dam:AssetContent" | ||
| sling:resourceType="fd/fm/af/render" | ||
| guide="1" | ||
| type="guide"> | ||
| <metadata | ||
| fd:version="2.1" | ||
| jcr:language="en" | ||
| jcr:primaryType="nt:unstructured" | ||
| xmp:CreatorTool="AEM Forms AF Wizard" | ||
| allowedRenderFormat="HTML" | ||
| author="admin" | ||
| dorType="none" | ||
| formmodel="none" | ||
| themeRef="/libs/fd/af/themes/canvas" | ||
| title="Add instances via loop"/> | ||
| </jcr:content> | ||
| </jcr:root> |
64 changes: 64 additions & 0 deletions
64
...ponents-it/samples/panelcontainer/repeatability-tests/add-instances-via-loop/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:fd="http://www.adobe.com/aemfd/fd/1.0" | ||
| jcr:primaryType="cq:Page"> | ||
| <jcr:content | ||
| cq:deviceGroups="[/etc/mobile/groups/responsive]" | ||
| cq:lastModified="{Date}2024-07-28T15:11:24.873+05:30" | ||
| cq:lastModifiedBy="admin" | ||
| cq:template="/conf/core-components-examples/settings/wcm/templates/af-blank-v2" | ||
| jcr:language="en" | ||
| jcr:primaryType="cq:PageContent" | ||
| jcr:title="Add instances via loop" | ||
| sling:configRef="/conf/forms/add-instances-via-loop/" | ||
| sling:resourceType="forms-components-examples/components/page" | ||
| ignoreTranslationInvalidation="{Boolean}true"> | ||
| <guideContainer | ||
| fd:version="2.1" | ||
| jcr:primaryType="nt:unstructured" | ||
| sling:resourceType="forms-components-examples/components/form/container" | ||
| dorType="none" | ||
| fieldType="form" | ||
| thankYouOption="page" | ||
| themeRef="/libs/fd/af/themes/canvas" | ||
| title="Add instances via loop"> | ||
| <panelcontainer | ||
| jcr:created="{Date}2024-07-28T15:10:40.615+05:30" | ||
| jcr:createdBy="admin" | ||
| jcr:lastModified="{Date}2024-07-28T15:11:24.871+05:30" | ||
| jcr:lastModifiedBy="admin" | ||
| jcr:primaryType="nt:unstructured" | ||
| jcr:title="Panel" | ||
| sling:resourceType="forms-components-examples/components/form/panelcontainer" | ||
| enabled="{Boolean}true" | ||
| fieldType="panel" | ||
| hideTitle="false" | ||
| name="panelcontainer" | ||
| readOnly="{Boolean}false" | ||
| repeatable="true" | ||
| textIsRich="[true,true,true]" | ||
| visible="{Boolean}true" | ||
| wrapData="{Boolean}false"> | ||
| <checkboxgroup | ||
| jcr:created="{Date}2024-07-28T15:11:03.827+05:30" | ||
| jcr:createdBy="admin" | ||
| jcr:lastModified="{Date}2024-07-28T15:11:19.032+05:30" | ||
| jcr:lastModifiedBy="admin" | ||
| jcr:primaryType="nt:unstructured" | ||
| jcr:title="Check Box Group" | ||
| sling:resourceType="forms-components-examples/components/form/checkboxgroup" | ||
| enabled="{Boolean}true" | ||
| enum="[0,1]" | ||
| enumNames="[Item 1, Item 2]" | ||
| fieldType="checkbox-group" | ||
| hideTitle="false" | ||
| name="checkbocx" | ||
| orientation="horizontal" | ||
| readOnly="{Boolean}false" | ||
| textIsRich="[true,true,true,true,true]" | ||
| type="string[]" | ||
| unboundFormElement="{Boolean}false" | ||
| visible="{Boolean}true"/> | ||
| </panelcontainer> | ||
| </guideContainer> | ||
| </jcr:content> | ||
| </jcr:root> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
.../test-module/specs/panelcontainer/panelcontainer.repeatability.addinstancevialoop.spec.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /******************************************************************************* | ||
| * Copyright 2024 Adobe | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| ******************************************************************************/ | ||
|
|
||
| describe("Repeatability Tests in Panel Container", () => { | ||
| const pagePath = "content/forms/af/core-components-it/samples/panelcontainer/repeatability-tests/add-instances-via-loop.html"; | ||
|
|
||
| let formContainer = null; | ||
|
|
||
| beforeEach(() => { | ||
| cy.previewFormWithPanel(pagePath).then(p => { | ||
| formContainer = p; | ||
| }); | ||
| }); | ||
|
|
||
| it("add instance using loop and change checkbox enums", () => { | ||
| const instanceManager = formContainer._model.items[0]; | ||
| const initialNoOfChild = instanceManager.items.length; | ||
| expect(initialNoOfChild).to.equal(1); | ||
| cy.get(".cmp-adaptiveform-container__wrapper") | ||
| .children() | ||
| .should("have.length", 1); | ||
|
|
||
| cy.wrap(null).then(() => { | ||
| for(let i=0; i < 4; i++) { | ||
| if(i !== 0) { | ||
| instanceManager.dispatch({type: "addItem"}); | ||
| } | ||
| const chbx = instanceManager.items[i].items[0]; | ||
| chbx.enum = [ "item1" + i, "item2" + i]; | ||
| chbx.enumNames = [ "Item1" + i, "Item2" + i]; | ||
| } | ||
| }) | ||
|
|
||
| cy.get(".cmp-adaptiveform-container__wrapper > div") | ||
| .should("have.length", 4); | ||
|
|
||
| cy.wrap(null).then(() => { | ||
| for(let i=0; i < 4; i++) { | ||
| const chbx = instanceManager.items[i].items[0]; | ||
| expect(chbx.enum).to.deep.equal([ "item1" + i, "item2" + i]); | ||
| expect(chbx.enumNames).to.deep.equal([ "Item1" + i, "Item2" + i]); | ||
| cy.get("#" + chbx.id + " [value='item1" + i + "']") | ||
| .should("be.visible"); | ||
| cy.get("#" + chbx.id + " [value='item2" + i + "']") | ||
| .should("be.visible"); | ||
| } | ||
| }) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.