Skip to content

Conversation

@navneet-ag
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

muskgupta and others added 6 commits August 21, 2024 15:01
…re components. (#1363)

* Fix default behaviour of enter press on form

* Updating tests

---------

Co-authored-by: Muskan Gupta <muskgupta@Muskans-MacBook-Pro.local>
#1355)

* FORMS-15150 Runtime client libraries are loaded in authoring for tabs and accordion

* FORMS-15150 Runtime client libraries are loaded in authoring for tabs, accordion, wizard

* FORMS-15150 adding test

* FORMS-15150 Runtime client libraries are loaded in authoring for tabs and accordion

* FORMS-15150 Runtime client libraries are loaded in authoring for tabs, accordion, wizard

* FORMS-15150 adding test

* FORMS-15150 null safe check

* FORMS-15150 fix tests

* FORMS-15150 fix tests
* localize code symbols

* Fixing test

* Fixing strings

* Fixing test

* Fixing test

* Fixing test

* Fixing test
* fix: adding exception for accessibility failing in the pipeline

* fix: hiding panel title, as its coming on top before the h1 tag to fix, page-has-heading-one, accessibility

---------

Co-authored-by: prateekawast <prateekawasthi@prateeks-mbp-2.corp.adobe.com>
* @releng updating af-core and af-custom-functions

* Fixing test
Co-authored-by: Pavitra Khatri <pavitrakhatri@Pavitras-MacBook-Pro.local>
Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com>
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 95 96 96 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
page-has-heading-one moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@rismehta rismehta merged commit 26217fa into master Sep 6, 2024
@rismehta rismehta deleted the dev_to_master_5Sept branch September 6, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants