Skip to content

FORMS-16296 Adding fragment test and fixing rules issue inside fragment #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 11, 2024
Merged

FORMS-16296 Adding fragment test and fixing rules issue inside fragment #1390

merged 7 commits into from
Sep 11, 2024

Conversation

@rismehta
Copy link
Collaborator

@rismehta rismehta commented Sep 10, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

vdua
vdua reviewed Sep 10, 2024
View reviewed changes
ui.tests/test-module/specs/fragment/fragment.runtime.spec.js
})

cy.get(`#${model.items[0].id}`).should('have.text', 'Thanks');
});
Copy link
Collaborator

@vdua vdua Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add a test case where the same fragment is added multiple times (need to check if core components provide new id to the fields)

Copy link
Collaborator Author

@rismehta rismehta Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Added the same

@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

1 similar comment
@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

1 similar comment
@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 96 75

@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Sep 10, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@rismehta rismehta merged commit 0947539 into dev Sep 11, 2024
@rismehta rismehta deleted the fragmentTest branch September 11, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdua vdua vdua left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rismehta @adobe-bot @vdua