Update strings.js#6980
Conversation
Update Italian translator.
|
@chrispecoraro Hello, Sorry but I am a new user in Brackets. Now what do I do? I need to close this "bug" by clicking on "close and comment". I would like the changes I made are accepted! |
|
I'm new as well... On Sun, Feb 23, 2014 at 12:21 PM, Denisov21 notifications@github.comwrote:
Not sent from an iPhone |
|
Ok, all fix!! |
There was a problem hiding this comment.
It seems like "lint files" should be translated here too (or at least "files"...)
There was a problem hiding this comment.
"linting al salvataggio"
There was a problem hiding this comment.
Or I think "Abilitazione del Lint al salvataggio dei file"
There was a problem hiding this comment.
Files is actually used as-is in Italian, I think that either "Linting al salvataggio" or "Lint Files al salvataggio" are good options while "Abilitazione del Lint al salvataggio" is too verbose and convoluted
There was a problem hiding this comment.
@peterflynn Hello, think about updating this file in time for the Release 37?
There was a problem hiding this comment.
@Denisov21 We have a deadline for merging translation pull requests near the end of each sprint. We send out a "last call for translations" message on brackets-dev to warn about the deadline; that hasn't happened yet for Sprint 37.
|
Hi @Denisov21, perhaps you should add the changes from PR #6973 and #6974 into this PR, since the review started here already. Thank you. |
|
Hi @ingorichter Yes, of course. It's a big idea. Thank you for your help me! |
|
@ingorichter Can you include in Spint 37 my changes? |
|
@Denisov21 I'm sorry that we are not able to include this in Sprint 37 anymore. We will target this for Sprint 38. @Denisov21 @artoale are you done with the review? I'd like to merge it. Thank you. |
|
LGTM :)
|
|
@ingorichter Sorry I know I made some mistakes but how can I merge? And how can I fix them? |
|
@artoale Hello, What do you mean "LGTM"? Can you help? |
|
@Denisov21 It's not bad to make mistakes. This is part of a learning process. I can go ahead and merge this PR if everybody is okay with the current translation. Regarding the two other PR's, I'll commenting on them and give you some instructions how to get them into one PR. BTW, I don't know the meaning of LGTM. ;-) |
|
LGTM = "looks good to me" :) Means it's good. |
I've updated the Italian language, with the corrections suggested by other users!
|
@ingorichter Hello, Thank you very much for your help. As I have written are a beginner, you will learn better with time using this tool you! |
|
@njx What does it mean PR? |
|
@Denisov21 Pull Request. |
|
@Denisov21 @artoale This looks good to me. If neither of you want to make changes anymore at this time, I'll go ahead and merge this PR (after we have the CLS check issue resolved!). All changes will appear in Sprint 38. I'm going to close #6973 in favor of this PR. Thanks for your effort getting the italian translation improved. |
|
Hi, @ingorichter, great idea! |
|
@Denisov21 Can you also add the SHA comment in your localized strings.js file? It is a recent change to the localization process and you can read Localization readme for more info on adding the SHA. |
|
@Denisov21 F.Y.I.: |
Check the translation, adding the string /* Last translated for 6FD7CEBAEAAC6CAF9FE6611E56F5CDAA008D4791 */
|
@RaymondLim , @ingorichter Hi, I add tthe SHA comment! |
|
@RaymondLim , @ingorichter Hi, I add the SHA comment! |
|
@Denisov21 Thanks for adding the SHA. Would you mind updating the SHA to the closest commit before you made changes to your clone of the repo? |
|
@ingorichter hi, I am confused I have not figured out how to create this SHA!
|
|
@Denisov21 You need to take the SHA from the history page of strings.js from root folder. You have to find out which version you used when you start your translation from that history page. Once you know the one you used, then you can mouse over that version and click on Copy SHA button when it shows up. |
|
@RaymondLim I'm sorry I can not find my edits! |
|
@Denisov21 How do you start the translation process? You need to diff two versions of strings.js from root folder and then copy each of changed blocks from the newer version and replace the same block in Italian version of strings.js file, right? If you have a similar process as I described, then you should have your local file that you can compare against with the history page to figure out which one you use. In the worst case, you have to look up from the very top in the history page and see you have those changes in your localized file. If you don't see the changes in your localized file, then you click on next one in the history page and repeat the process of locating the changes in your localized file. Then you will figure out which one is the one you used and you can copy SHA from that one. |
|
@Denisov21 You don't need any program to get the SHA. You can either use github.com or the local git program to get this information. |
7 participants
Update Italian translator.