Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Update strings.js#6973

Closed
Denisov21 wants to merge 1 commit intoadobe:masterfrom
Denisov21:patch-1
Closed

Update strings.js#6973
Denisov21 wants to merge 1 commit intoadobe:masterfrom
Denisov21:patch-1

Conversation

@Denisov21
Copy link
Copy Markdown
Contributor

I have fix any bug in Italian translate!

I have fix any bug in Italian translate!
@redmunds
Copy link
Copy Markdown
Contributor

Re-opening. Thank you for your contribution. First we need another Italian speaker to review your changes. Then a Brackets committer will need to merge your changes.

@redmunds redmunds reopened this Feb 23, 2014
@chrispecoraro
Copy link
Copy Markdown
Contributor

I can check them over.

On Sun, Feb 23, 2014 at 4:15 PM, Randy Edmunds notifications@github.comwrote:

Reopened #6973 #6973.

Reply to this email directly or view it on GitHubhttps://github.com//pull/6973
.

Not sent from an iPhone

@ingorichter ingorichter self-assigned this Feb 24, 2014
@ingorichter ingorichter mentioned this pull request Feb 25, 2014
@ingorichter
Copy link
Copy Markdown
Contributor

Hi @Denisov21, thank you very much for the translation update. Would you mind to combine all three PR #6974, #6973 and #6980 into one PR? It's much easier for another native speaker to review and we have all the changes in one PR. Thank you very much.

@chrispecoraro It would be great if you could review all the changes to the italian translation. That is greatly appreciated. Thanks.

@ingorichter ingorichter mentioned this pull request Feb 25, 2014
@Denisov21
Copy link
Copy Markdown
Contributor Author

Hi @ingorichter, yes I think is a big idea! Sorry for Excuse me for having opened so many PR. I am a new user and it was my first time I opened a bug in a program Open Source. Thank you for your help!

@ingorichter
Copy link
Copy Markdown
Contributor

Hi @Denisov21, I think the best solution is to take the changes from #6974 and add them to the string.js file of this pull request (select this branch patch- first). Since #6974 contains only a few changes, this makes the most sense to me. Once you made the changes to this PR (on branch patch-1), you can basically close #6974 and we can focus on this pull request to get it into the next release. Makes sense?

@Denisov21
Copy link
Copy Markdown
Contributor Author

Hi @ingorichter Yes of course!

@ingorichter
Copy link
Copy Markdown
Contributor

Closed in favor of #6980.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants