This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Conversation
[cmv4] Prevent modification of codemirror cursor position
Add missing param
Fix remaining cmv4 FindReplace unit tests
[cmv4] Fix LanguageManager unit test
…n various jslint directives
…lready fixed in cmv4
…empty and the user cancels out
[cmv4] Preserve multiple selections in various Esc cases
…dd a parameter to let the caller get all selections
[cmv4] Populate Quick Open from primary selection only
[cmv4] Fix merging of edits in inline color editor
…f argument for each of them
[cmv4] Fix unit tests for getSelectedText() to reflect new behavior
…election is a range in the middle of the line to insert tab/spaces at beginning instead of replacing selection.
[cmv4] Implement Tab key heuristics for multiple selections
[cmv4] Fix case of hitting Tab at the beginning of a whitespace-only line
Author
|
Smoke and unit tests all pass on Mac and Win. Merging. |
njx
pushed a commit
that referenced
this pull request
Mar 12, 2014
Integrate CodeMirror v4 and implement multiple selections
Author
|
Leaving the branch for now for reference (not deleting it). We can delete it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Landing the CodeMirror v4 work into master. See the multiple selections spec and the CodeMirror v4 upgrade guide for more details.
Thanks to @marijnh for all his work on multiple selections in CodeMirror v4.