Skip to content

feat(ew): handle read-only users correctly in EW - #1174

Merged
usman-khalid merged 4 commits into
mainfrom
ronly
Jul 29, 2026
Merged

feat(ew): handle read-only users correctly in EW#1174
usman-khalid merged 4 commits into
mainfrom
ronly

Conversation

@usman-khalid

@usman-khalid usman-khalid commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Must land with adobe/da-nx#616

Handles read-only access in EW correctly.

  • Add a lock icon (and update DA to the newer s2 lock icon for consistency) in the EW canvas header.
  • Remove undo/redo buttons for read-only users
  • Don't render toolbars for read-only users since they can't make any updates
  • Prevent read-only users from making edits that silently fail or never persist:
    • Phantom text updates in layout mode that are never persisted
    • Remove image drag & drop for read-only users, which fails silently with a 403, giving the user a false impression they could take that action

Fixes #1107

image image

@aem-code-sync

aem-code-sync Bot commented Jul 23, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

Comment thread blocks/canvas/ew-canvas-header/ew-canvas-header.css Outdated
@sharanyavinod

Copy link
Copy Markdown
Contributor

@usman-khalid Thank you for the contribution! Code looks good, just have a minor comment.
Also, there are a couple e2es failing related to the changes introduced, so could you take a look at those as well please?

@usman-khalid
usman-khalid merged commit 895ff7e into main Jul 29, 2026
5 checks passed
@usman-khalid
usman-khalid deleted the ronly branch July 29, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EW] Handle read-only users in EW correctly

2 participants