Skip to content

chore: improve test file cleanup - #1179

Merged
sharanyavinod merged 7 commits into
mainfrom
ewtest
Jul 31, 2026
Merged

chore: improve test file cleanup#1179
sharanyavinod merged 7 commits into
mainfrom
ewtest

Conversation

@sharanyavinod

Copy link
Copy Markdown
Contributor

Description

  • Cleanup test files created immediately after test execution
  • Existing logic for cleaning up test files older than 2 hours still kept as a fallback

Related Issue

Fixes #1149

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aem-code-sync

aem-code-sync Bot commented Jul 27, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@sharanyavinod
sharanyavinod marked this pull request as draft July 27, 2026 12:34
@sharanyavinod
sharanyavinod marked this pull request as ready for review July 28, 2026 08:54

@hannessolo hannessolo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely makes sense - only question I have is do we still have an e2e testing deletion via the UI? It would probably make sense to still have a test that covers it.

@sharanyavinod

Copy link
Copy Markdown
Contributor Author

@hannessolo Yes, Create Delete Document in edit.spec.js still does delete through UI

@sharanyavinod
sharanyavinod merged commit 4583e05 into main Jul 31, 2026
5 checks passed
@sharanyavinod
sharanyavinod deleted the ewtest branch July 31, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve e2e test files cleanup

2 participants