feat(canvas): merge/split cells from the slash menu on cell selection - #1212
Merged
Conversation
hannessolo
marked this pull request as ready for review
August 5, 2026 14:19
Classic-editor parity: pressing "/" with one or more table cells selected now opens a menu offering Merge cells / Split cell (without inserting a "/"), instead of merge being reachable only from the floating selection toolbar. Wired into the existing slash-menu plugin, which already owns the nx-menu element, positioning, and keyboard nav. A `cellMode` flag routes selection to the command directly (no "/query" text to strip) and keeps syncSlashUi from closing the menu until the cell selection ends. Cell selection is detected via duck-typed `$anchorCell` rather than `instanceof CellSelection`, which is fragile across bundled module copies. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replace the hardcoded CELL_SELECTION_COMMAND_IDS list with a 'slash-cell' showIn tag on the merge/split cell commands, so cellSelectionSlashItems derives its commands via commandsFor() like every other slash/toolbar surface. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sharanyavinod
approved these changes
Aug 18, 2026
mhaack
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://cellmenu--da-live--adobe.aem.live