Conversation
Covers the /edit <-> /canvas redirect behavior (#1289, #1290, #1299): first-time toggle-on shows the welcome dialog and sets the nx2:ew-user-enabled flag, /edit keeps redirecting to /canvas while the flag is set, and toggling off in the profile menu clears the flag and stops the redirect. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
mhaack
requested review from
anfibiacreativa,
bosschaert,
hannessolo,
rofe and
sharanyavinod
September 7, 2026 10:09
rofe
previously approved these changes
Sep 7, 2026
| @@ -1,3 +1,3 @@ | |||
| import getPathDetails from '../shared/pathDetails.js'; | |||
| import { contentLogin, livePreviewLogin } from '../shared/utils.js'; | |||
| import { getNx, getNx2Api, getNxEWFlags } from '../../scripts/utils.js'; | |||
Contributor
Author
|
@rofe can you please re-approve, lint issue is now fixed, was trying out things |
rofe
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/e2e/tests/usertoggle.spec.js, covering the/edit↔/canvasExperience Workspace redirect behavior added in fix: redirect /edit to /canvas when Experience Workspace is enabled #1290/fix: strip .html extension when redirecting /edit to /canvas #1299:/edit→/canvas, shows the one-time welcome dialog, and sets thenx2:ew-user-enabledlocalStorage flag./editkeeps redirecting to/canvas./edit, and a subsequent/editvisit no longer redirects.Test:
Test plan
npm run test -- tests/usertoggle.spec.js(ornpm run test:ui) against an environment with Experience Workspace enabled