Conversation
| ? { name: prevSib.textContent } | ||
| : getBlockName(block.className || ''); | ||
| let item; | ||
| if (block.dataset.groupheading) { |
Member
There was a problem hiding this comment.
maybe worth adding a test for the three branches in transformBlock (groupheading attr, heading sibling, fallback to getBlockName). without it the same thing can regress silently.
Contributor
Author
There was a problem hiding this comment.
Yes I agree, added tests
| : getBlockName(block.className || ''); | ||
| let item; | ||
| if (block.dataset.groupheading) { | ||
| item = { name: block.dataset.groupheading }; |
Member
There was a problem hiding this comment.
is this data-groupheading (one word) or data-group-heading? the dataset key needs to match exactly.
Contributor
Author
There was a problem hiding this comment.
This is correct:
block
<div data-isgroup="true" data-groupheading="Hero with text">…</div>
block.dataset
DOMStringMap {isgroup: 'true', groupheading: 'Hero with text'}
chrischrischris
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test:
fixes: https://jira.corp.adobe.com/browse/SITES-45828
Before:
After:
