Skip to content

fix: block library missing title for grouped blocks #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhaack merged 5 commits into from
Jun 2, 2026
+192 −3
Merged

fix: block library missing title for grouped blocks #976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33216be
fix: EW block library title parsing for grouped blocks
mhaack May 29, 2026
02798a4
fix: typo
mhaack May 29, 2026
c6dcf19
fix: lint errors
mhaack May 29, 2026
311064e
fix: add test
mhaack Jun 1, 2026
5ed2978
Merge branch 'main' into ew-lib
mhaack Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions blocks/canvas/ew-panel-extensions/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,14 @@ function getLibraryMetadata(el) {

function transformBlock(block) {
const prevSib = block.previousElementSibling;
const item = isHeading(prevSib) && prevSib.textContent
? { name: prevSib.textContent }
: getBlockName(block.className || '');
let item;
if (block.dataset.groupheading) {
Copy link
Copy Markdown
Member

@anfibiacreativa anfibiacreativa May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth adding a test for the three branches in transformBlock (groupheading attr, heading sibling, fallback to getBlockName). without it the same thing can regress silently.

Copy link
Copy Markdown
Contributor Author

@mhaack mhaack Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree, added tests

item = { name: block.dataset.groupheading };
Copy link
Copy Markdown
Member

@anfibiacreativa anfibiacreativa May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this data-groupheading (one word) or data-group-heading? the dataset key needs to match exactly.

Copy link
Copy Markdown
Contributor Author

@mhaack mhaack May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct:

block
<div data-isgroup=​"true" data-groupheading=​"Hero with text">​…​</div>​

block.dataset
DOMStringMap {isgroup: 'true', groupheading: 'Hero with text'}

} else if (isHeading(prevSib) && prevSib.textContent) {
item = { name: prevSib.textContent };
} else {
item = getBlockName(block.className || '');
}
item.dom = block.dataset?.isgroup ? processGroupBlock(block) : getBlockTableHtml(block);

const metaEl = block.nextElementSibling?.classList.contains('library-metadata')
Expand Down
3 changes: 3 additions & 0 deletions test/fixtures/nx/utils/daConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// Mock NX /utils/daConfig.js utils for tests
export const fetchDaConfigs = async () => ({});
export const getFirstSheet = () => null;
181 changes: 181 additions & 0 deletions test/unit/blocks/canvas/ew-panel-extensions/helpers.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,181 @@
import { expect } from '@esm-bundle/chai';
import { setNx } from '../../../../../scripts/utils.js';

setNx('/test/fixtures/nx', { hostname: 'example.com' });

let getBlockVariants;

before(async () => {
const mod = await import('../../../../../blocks/canvas/ew-panel-extensions/helpers.js');
getBlockVariants = mod.getBlockVariants;
});

describe('EW panel helpers transformBlock', () => {
let savedFetch;
beforeEach(() => { savedFetch = window.fetch; });
afterEach(() => { window.fetch = savedFetch; });

function mockHtml(html) {
window.fetch = () => Promise.resolve(new Response(html, { status: 200 }));
}

it('Uses data-groupheading as the name for grouped blocks', async () => {
mockHtml(`
<body><div>
<h2>My Group</h2>
<div class="library-container-start"></div>
<div class="hero"><div><div>content</div></div></div>
<div class="library-container-end"></div>
</div></body>
`);
const variants = await getBlockVariants('/mock-path');
expect(variants).to.have.lengthOf(1);
expect(variants[0].name).to.equal('My Group');
});

it('Falls back to the preceding heading text when no groupheading', async () => {
mockHtml(`
<body><div>
<h2>Block Title</h2>
<div class="hero"><div><div>content</div></div></div>
</div></body>
`);
const variants = await getBlockVariants('/mock-path');
expect(variants).to.have.lengthOf(1);
expect(variants[0].name).to.equal('Block Title');
});

it('Falls back to class name when there is no groupheading and no preceding heading', async () => {
mockHtml(`
<body><div>
<div class="hero wide"><div><div>content</div></div></div>
</div></body>
`);
const variants = await getBlockVariants('/mock-path');
expect(variants).to.have.lengthOf(1);
expect(variants[0].name).to.equal('hero');
expect(variants[0].variants).to.equal('wide');
});

it('Returns an empty array when the fetch fails', async () => {
window.fetch = () => Promise.resolve(new Response('error', { status: 500 }));
const variants = await getBlockVariants('/mock-path');
expect(variants).to.deep.equal([]);
});

it('Returns a table as item.dom for a regular block', async () => {
mockHtml(`
<body><div>
<div class="hero"><div><div>content</div></div></div>
</div></body>
`);
const variants = await getBlockVariants('/mock-path');
expect(variants[0].dom).to.be.instanceOf(window.HTMLTableElement);
});

it('Returns a div as item.dom for a grouped block', async () => {
mockHtml(`
<body><div>
<h2>My Group</h2>
<div class="library-container-start"></div>
<div class="hero"><div><div>content</div></div></div>
<div class="library-container-end"></div>
</div></body>
`);
const variants = await getBlockVariants('/mock-path');
expect(variants[0].dom).to.be.instanceOf(window.HTMLDivElement);
});

it('Sets item.tags from searchtags in nextElementSibling library-metadata', async () => {
mockHtml(`
<body><div>
<div class="hero"><div><div>content</div></div></div>
<div class="library-metadata"><div><div>searchtags</div><div>hero, card</div></div></div>
</div></body>
`);
const variants = await getBlockVariants('/mock-path');
expect(variants[0].tags).to.equal('hero, card');
});

it('Sets item.description from description in nextElementSibling library-metadata', async () => {
mockHtml(`
<body><div>
<div class="hero"><div><div>content</div></div></div>
<div class="library-metadata"><div><div>description</div><div>A hero block</div></div></div>
</div></body>
`);
const variants = await getBlockVariants('/mock-path');
expect(variants[0].description).to.equal('A hero block');
});

it('Sets item.tags from searchtags in embedded library-metadata', async () => {
mockHtml(`
<body><div>
<div class="hero">
<div><div>content</div></div>
<div class="library-metadata"><div><div>searchtags</div><div>hero, banner</div></div></div>
</div>
</div></body>
`);
const variants = await getBlockVariants('/mock-path');
expect(variants[0].tags).to.equal('hero, banner');
});

it('Sets both tags and description when both present in library-metadata', async () => {
mockHtml(`
<body><div>
<div class="hero"><div><div>content</div></div></div>
<div class="library-metadata">
<div><div>searchtags</div><div>hero, card</div></div>
<div><div>description</div><div>A hero block</div></div>
</div>
</div></body>
`);
const variants = await getBlockVariants('/mock-path');
expect(variants[0].tags).to.equal('hero, card');
expect(variants[0].description).to.equal('A hero block');
});

it('Does not set tags or description when no library-metadata is present', async () => {
mockHtml(`
<body><div>
<div class="hero"><div><div>content</div></div></div>
</div></body>
`);
const variants = await getBlockVariants('/mock-path');
expect(variants[0].tags).to.be.undefined;
expect(variants[0].description).to.be.undefined;
});

it('Sets tags from library-metadata appended after library-container-end in a group', async () => {
mockHtml(`
<body><div>
<h2>My Group</h2>
<div class="library-container-start"></div>
<div class="hero"><div><div>content</div></div></div>
<div class="library-container-end"></div>
<div class="library-metadata"><div><div>searchtags</div><div>group, hero</div></div></div>
</div></body>
`);
const variants = await getBlockVariants('/mock-path');
expect(variants[0].tags).to.equal('group, hero');
});

it('Group dom contains both a table for the block and cloned non-div siblings', async () => {
mockHtml(`
<main><div>
<h2>Hero with text</h2>
<div class="library-container-start"><div><div></div></div></div>
<div class="hero"><div><div>content</div></div></div>
<p>Lorem ipsum</p>
<div class="library-container-end"><div><div></div></div></div>
</div></main>
`);
const variants = await getBlockVariants('/mock-path');
expect(variants[0].name).to.equal('Hero with text');
const { dom } = variants[0];
expect(dom).to.be.instanceOf(window.HTMLDivElement);
expect(dom.querySelector('table')).to.not.be.null;
expect(dom.querySelector('p')).to.not.be.null;
});
});
Loading