Skip to content

feat(ew): show loading spinner on preview & publish#592

Merged
usman-khalid merged 4 commits into
mainfrom
spin
Jul 14, 2026
Merged

feat(ew): show loading spinner on preview & publish#592
usman-khalid merged 4 commits into
mainfrom
spin

Conversation

@usman-khalid

Copy link
Copy Markdown
Contributor

Currently there's no visual cue that something is in progress when a page is previewed or published from the paper airplane in ew-actions.

Adds a loading spinner.

2026-07-09 20 37 44

@aem-code-sync

aem-code-sync Bot commented Jul 10, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@mhaack

mhaack commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

I like the idea, but instead of the spinner, should we use the flying paper plane like we have in the stock base editor? @sharanyavinod any thoughts?

@usman-khalid

Copy link
Copy Markdown
Contributor Author

I like the idea, but instead of the spinner, should we use the flying paper plane like we have in the stock base editor? @sharanyavinod any thoughts?

I know that's what we currently have in DA, but the spinner is standard for loading experiences in Spectrum: https://opensource.adobe.com/spectrum-web-components/components/progress-circle/

@mhaack

mhaack commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

ACK, lets keep the spinner then

@sharanyavinod

Copy link
Copy Markdown
Contributor

We have multiple spinners across components now, so this would anyway need to be extracted to be a common, reusable class. For now, can stay as is. Thanks for the contribution!

@usman-khalid

Copy link
Copy Markdown
Contributor Author

We have multiple spinners across components now, so this would anyway need to be extracted to be a common, reusable class. For now, can stay as is. Thanks for the contribution!

Created #599 to track

@usman-khalid usman-khalid merged commit bdbf9c9 into main Jul 14, 2026
3 checks passed
@usman-khalid usman-khalid deleted the spin branch July 14, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants