feat(chat): batched tool-approval protocol (v2) - #617
Merged
Conversation
Rework the chat client's approval handling so a multi-tool approval step is answered correctly, and own the client↔agent wire contract with no external library dependency: - Single source of truth: tool activity lives as `type:'tool'` parts on assistant messages, each carrying a lifecycle `state`; toolCards are derived. - Batched approvals: decisions are recorded per part and one POST is sent only once the whole approval queue is drained (fixes one-at-a-time round-trips); sent-tracking prevents rejection resend loops. - Stream: consume tool-input-available / tool-approval-request / tool-output-available|error; drop approvalId, role:'tool' messages, and the orphan-stripping/virtual-message machinery. - migrateHistory(): best-effort v1 -> v2 for persisted conversations. - Point ?ref=local at the agent's native port 4002 (reconciled from 4200). - Docs: new approval-protocol.md (canonical contract) + chat-ui-component.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
hannessolo
marked this pull request as ready for review
July 31, 2026 11:05
sharanyavinod
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the chat client's approval handling so a multi-tool approval step is answered correctly, and own the client↔agent wire contract with no external library dependency:
type:'tool'parts on assistant messages, each carrying a lifecyclestate; toolCards are derived.Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: