fix(loc): authenticate google translate requests with IMS token - #628
Merged
Conversation
translate.da.live now requires /translate/<service>/<org>/<site> routes with a valid IMS bearer token (adobe/da-translate#5). Move the google connector off the anonymous /google endpoint onto the new authenticated route via daFetch.
sharanyavinod
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/translate/<service>/<org>/<site>routes that require a valid IMS bearer token (adobe/da-translate#5). Legacy/googleand/smartlingremain for now but are deprecated server-side.POST /googlecall onto${DA_TRANSLATE}/translate/google/<org>/<site>viadaFetch, which attaches the IMS bearer token.translate.da.livetoALLOWED_TOKENinnx2/utils/utils.jssodaFetchknows to attach auth for that origin.Test plan
npm run lintnpm test(1115 passing, includes newtest/loc/connectors/google/index.test.js)