Skip to content

fix: resolve retry/resume issues + code cleanup - #712

Merged
sharanyavinod merged 3 commits into
mainfrom
ewaoui
Sep 2, 2026
Merged

fix: resolve retry/resume issues + code cleanup#712
sharanyavinod merged 3 commits into
mainfrom
ewaoui

Conversation

@sharanyavinod

@sharanyavinod sharanyavinod commented Sep 1, 2026

Copy link
Copy Markdown
Contributor
  • Fixes error scenario when socket is dropped during questions/user inputs
  • Muted ux on schema retry errors
  • Code cleanup

@aem-code-sync

aem-code-sync Bot commented Sep 1, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits


// AO surfaces a blind tool's schema on first call as a status:"error" retry
// step, not a real failure — see docs/chat-ao-component.md#tool-call-activity.
const DEFERRED_SCHEMA_RESULT_PREFIX = 'Loaded schema for ';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're keying retry-vs-error off a prose prefix from the backend. that breaks silently the day AO changes the wording. is there really no structured signal (a status/error_type field) we can gate on instead? at minimum worth a comment on the AO side that this string is now a contract.

@sharanyavinod sharanyavinod Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just in the interim until we figure out what exactly is causing the issue. And in the end all this does on the client side is swap out the label to not show ERROR explicitly - all communication stays the same and responses and still intact when expanded
AO does the retry itself, not on demand by the UI - our changes are purely cosmetic

@sharanyavinod sharanyavinod Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can avoid status in the tool call altogether so we can sidestep this whole concern atleast from client perspective. Coworker does something similar - it has the same issues, just not very visible to the user. For this I would like to discuss with Kilian, so might the current solution make sense in the interim? Wdyt?

Comment thread nx2/blocks/chat-ao/utils/episodes.js
@sharanyavinod
sharanyavinod merged commit 2ef50bb into main Sep 2, 2026
3 checks passed
@sharanyavinod
sharanyavinod deleted the ewaoui branch September 2, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants