fix: parse saturation param from theme URL config#258
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the
saturationparameter in theme URL configs is ignored, causing themes to always load with 100% saturation regardless of the URL parameter value.Problem
When users share Leonardo theme URLs with a specific
saturationvalue in the config (e.g.,"saturation": 20), the web UI ignores this parameter and defaults to 100% saturation. This breaks the ability to share complete theme configurations via URL.Fix
Added saturation parameter parsing that:
config.saturationfrom the URL parameter_theme.saturationpropertyThe implementation follows the exact same pattern used for the existing
contrastparameter (lines 112-116), ensuring consistency with the codebase. The fix is minimal and improves theme sharing.