fix: make home icon navigate to site root on theme, scales, and tools pages#277
Merged
Conversation
… pages Replace in-page tab switch with actual navigation to / so the home icon links go to leonardocolor.io/ instead of changing content in-place. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Contributor
Run report for 09e3516fTotal time: 27.7s | Comparison time: 25.5s | Estimated loss: 2.2s (8.1% slower)
Touched files |
- Remove tab_home partial from theme, scales, and tools pages (unreachable after home icon now navigates to index.html) - Remove welcome.click() calls and openSideNavItem imports from theme.js, scales.js, tools.js - Remove target="_blank" from homepage navigation cards so theme/scales/tools open in the same tab - Normalize home icon href to index.html for consistency with other links - Delete orphaned files: index.js, header.html, tab_home.html, home_sidenav.html Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On theme.html, scales.html, and tools.html, the home icon previously called
openAppTab(event, 'home')and only changed the in-page content. It now navigates to the site root (e.g. https://leonardocolor.io/) via an<a href="/">link.Changes:
docs/ui/src/views/header_theme.html– home tab → link to /docs/ui/src/views/header_scales.html– home tab → link to /docs/ui/src/views/header_tools.html– home tab → link to /Made with Cursor