fix: prevent Android Chrome taps from being detected as drag event#10332
Merged
Conversation
| writeToDataTransfer | ||
| } from './utils'; | ||
| import intlMessages from '../../intl/dnd/*.json'; | ||
| import {isIOS} from '../utils/platform'; |
|
Build successful! 🎉 |
snowystinger
approved these changes
Jul 16, 2026
devongovett
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slack reported issue
✅ Pull Request Checklist:
📝 Test Instructions:
Go to the S1 storybook -> Drag and Drop default story. Make sure tapping on the "Drag me" button doesn't start drag in Android Chrome. Make sure you can still drag and drop in iOS VoiceOver via double tapping said button and smoke check drag and drop on all other device/OS combos
NOTE: NVDA/JAWS keyboard drag and drop is broken due to #10310 it seems, unrelated to the changes in this PR
🧢 Your Project:
RSP