chore: omit shouldSkipAnimation from s2 popover - #10400
Merged
Merged
Conversation
devongovett
approved these changes
Jul 30, 2026
LFDanLu
enabled auto-merge
July 30, 2026 21:26
yihuiliao
approved these changes
Jul 30, 2026
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2/@react-spectrum/s2:PopoverProps PopoverProps {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
arrowRef?: RefObject<Element | null>
boundaryElement?: Element = document.body
children?: ChildrenOrFunction<PopoverRenderProps>
containerPadding?: number = 12
crossOffset?: number = 0
defaultOpen?: boolean
getTargetRect?: (Element) => DOMRect | null | undefined = target.getBoundingClientRect()
hideArrow?: boolean = false
isEntering?: boolean
isExiting?: boolean
isNonModal?: boolean
isOpen?: boolean
maxHeight?: number
offset?: number = 8
onBlurWithin?: (FocusEvent) => void
onFocusWithin?: (FocusEvent) => void
onFocusWithinChange?: (boolean) => void
onOpenChange?: (boolean) => void
placement?: Placement = 'bottom'
scrollRef?: RefObject<Element | null> = overlayRef
shouldFlip?: boolean = true
- shouldSkipAnimation?: boolean
size?: 'S' | 'M' | 'L'
slot?: string | null
styles?: StyleString
trigger?: string
} |
Agent Skills ChangesModified (3)
InstallReact Spectrum S2: React Aria: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
audit
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP