Skip to content

chore: omit shouldSkipAnimation from s2 popover - #10400

Merged
LFDanLu merged 2 commits into
mainfrom
more_api_audit
Jul 30, 2026
Merged

chore: omit shouldSkipAnimation from s2 popover#10400
LFDanLu merged 2 commits into
mainfrom
more_api_audit

Conversation

@LFDanLu

@LFDanLu LFDanLu commented Jul 30, 2026

Copy link
Copy Markdown
Member

audit

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@LFDanLu LFDanLu changed the title chore: omit point, setPoint from non-menu components and omit shouldSkipAnimation from s2 popover chore: omit shouldSkipAnimation from s2 popover Jul 30, 2026
@LFDanLu
LFDanLu enabled auto-merge July 30, 2026 21:26
@rspbot

rspbot commented Jul 30, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Jul 30, 2026

Copy link
Copy Markdown
## API Changes

@react-spectrum/s2

/@react-spectrum/s2:PopoverProps

 PopoverProps {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   aria-describedby?: string
   aria-details?: string
   aria-label?: string
   aria-labelledby?: string
   arrowRef?: RefObject<Element | null>
   boundaryElement?: Element = document.body
   children?: ChildrenOrFunction<PopoverRenderProps>
   containerPadding?: number = 12
   crossOffset?: number = 0
   defaultOpen?: boolean
   getTargetRect?: (Element) => DOMRect | null | undefined = target.getBoundingClientRect()
   hideArrow?: boolean = false
   isEntering?: boolean
   isExiting?: boolean
   isNonModal?: boolean
   isOpen?: boolean
   maxHeight?: number
   offset?: number = 8
   onBlurWithin?: (FocusEvent) => void
   onFocusWithin?: (FocusEvent) => void
   onFocusWithinChange?: (boolean) => void
   onOpenChange?: (boolean) => void
   placement?: Placement = 'bottom'
   scrollRef?: RefObject<Element | null> = overlayRef
   shouldFlip?: boolean = true
-  shouldSkipAnimation?: boolean
   size?: 'S' | 'M' | 'L'
   slot?: string | null
   styles?: StyleString
   trigger?: string
 }

@rspbot

rspbot commented Jul 30, 2026

Copy link
Copy Markdown

Agent Skills Changes

Modified (3)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/2cffcde7b2fcb9743b056aad89325c6c3d8b92e8/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/2cffcde7b2fcb9743b056aad89325c6c3d8b92e8/

@LFDanLu
LFDanLu added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit 2247abc Jul 30, 2026
31 checks passed
@LFDanLu
LFDanLu deleted the more_api_audit branch July 30, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants