fix: tooltip prop spread in s2 docs examples - #10413
Open
snowystinger wants to merge 1 commit into
Open
Conversation
|
Build successful! 🎉 |
Agent Skills ChangesModified (2)
InstallReact Spectrum S2: React Aria: |
yihuiliao
approved these changes
Aug 3, 2026
yihuiliao
left a comment
Member
There was a problem hiding this comment.
If you toggle the two default true boolean, they should render with 'false' explicitly in the example
I'm confused by this. Where can I toggle this?
| ); | ||
| } else if (typeof value === 'boolean') { | ||
| if (value === false && control?.optional) { | ||
| if (value === false && control?.optional && !control?.default) { |
Member
There was a problem hiding this comment.
out of curiosity, what was this change for?
Member
Author
Member
There was a problem hiding this comment.
ohh okay i see what you mean, ty
reidbarber
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #10411
✅ Pull Request Checklist:
📝 Test Instructions:
Open example in stackblitz, no ts error
If you toggle the two default true boolean, they should render with 'false' explicitly in the example
🧢 Your Project: