feat: PromptField animation, AI button, and loader updates - #10425
Merged
Conversation
|
Build successful! 🎉 |
Agent Skills ChangesModified (2)
InstallReact Spectrum S2: React Aria: |
LFDanLu
approved these changes
Aug 4, 2026
LFDanLu
left a comment
LFDanLu
left a comment
Member
There was a problem hiding this comment.
LGTM, lets get this merged so I can pull in the AIButton for the demo via nightly
snowystinger
approved these changes
Aug 5, 2026
| import {pressScale} from '@react-spectrum/s2/pressScale'; | ||
|
|
||
| export interface AIButtonProps extends Omit< | ||
| ButtonProps, |
Member
There was a problem hiding this comment.
also omit excludeFromTabOrder?
In a similar comment though, i think we keep preventFocusOnPress if it's being used in prompt so the cursor can stay in the field?
Member
Author
There was a problem hiding this comment.
hmm we don't omit those from S2 though
| } | ||
| }); | ||
|
|
||
| defineProperties(` |
Member
There was a problem hiding this comment.
can this be defined multiple times? what if two instances define it with a different initial-value?
Member
Author
There was a problem hiding this comment.
it can and the last one wins. lightningcss will deduplicate them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note change in S2 Provider: the
--s2-color-schemevar is now alwayslightordarkand notlight dark. This allows it to be used in container style queries to adjust styles based on the correct color scheme (both app set and OS set).