fix(ActionBar): fix icon color in close button in emphasized ActionBar - #10429
Merged
Conversation
yihuiliao
approved these changes
Aug 5, 2026
snowystinger
approved these changes
Aug 5, 2026
snowystinger
left a comment
Member
There was a problem hiding this comment.
thanks, not sure how i missed that when i updated the other button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a contrast failure in the S2 ActionBar's clear button. In dark mode with
isEmphasized, the close button's icon was hardcoded to white, which failed contrast against the ActionBar background color.Changed to
transparent-overlay-1000, which auto-computes black or white based on the--s2-container-bginherited from the container.Also added a chromatic story.
Before:
After:
✅ Pull Request Checklist:
📝 Test Instructions:
Verify in docs/storybook and check new Chromatic story.
🧢 Your Project: