Skip to content

Dialogs and theme switching - #226

Merged
dannify merged 12 commits into
masterfrom
fix-and-test-dialog-theme-switching
Feb 29, 2020
Merged

Dialogs and theme switching#226
dannify merged 12 commits into
masterfrom
fix-and-test-dialog-theme-switching

Conversation

@snowystinger

Copy link
Copy Markdown
Member

Add tests so that we don't break this in the future
Fixed logic in determining which theme to use // importance parent > OS > default > omitted
added a mocking library so that we can change match media during tests easily

Closes https://jira.corp.adobe.com/browse/RSP-1527

✅ Pull Request Checklist:

  • Included link to corresponding Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Team:

Fixed logic in determining which theme to use   // importance parent > OS > default > omitted
added a mocking library so that we can change match media during tests easily
LFDanLu
LFDanLu previously approved these changes Feb 26, 2020

@LFDanLu LFDanLu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to fix the lint issues

@adobe-bot

Copy link
Copy Markdown

Build successful! 🎉

@adobe-bot

Copy link
Copy Markdown

Build successful! 🎉

@adobe-bot

Copy link
Copy Markdown

Build successful! 🎉

@adobe-bot

Copy link
Copy Markdown

Build successful! 🎉

@adobe-bot

Copy link
Copy Markdown

Build successful! 🎉

@adobe-bot

Copy link
Copy Markdown

Build successful! 🎉

@adobe-bot

Copy link
Copy Markdown

Build successful! 🎉

@adobe-bot

Copy link
Copy Markdown

Build successful! 🎉

@adobe-bot

Copy link
Copy Markdown

Build successful! 🎉

@codecov

codecov Bot commented Feb 28, 2020

Copy link
Copy Markdown

Codecov Report

Merging #226 into master will increase coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
+ Coverage   69.44%   70.57%   +1.13%     
==========================================
  Files         206      206              
  Lines        3973     3973              
  Branches      847      847              
==========================================
+ Hits         2759     2804      +45     
+ Misses        625      588      -37     
+ Partials      589      581       -8
Impacted Files Coverage Δ
...ges/@react-spectrum/tooltip/src/TooltipTrigger.tsx 92.85% <0%> (+7.14%) ⬆️
...kages/@react-aria/tooltip/src/useTooltipTrigger.ts 88.46% <0%> (+11.53%) ⬆️
packages/@react-aria/tooltip/src/useTooltip.ts 75% <0%> (+25%) ⬆️
...es/@react-aria/interactions/src/DOMPropsContext.ts 83.33% <0%> (+33.33%) ⬆️
packages/@react-aria/interactions/src/useHover.ts 73.52% <0%> (+44.11%) ⬆️
...kages/@react-stately/tooltip/src/TooltipManager.ts 69.23% <0%> (+50%) ⬆️
...@react-aria/interactions/src/DOMPropsResponder.tsx 87.5% <0%> (+75%) ⬆️

@adobe-bot

Copy link
Copy Markdown

Build successful! 🎉

@LFDanLu LFDanLu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannify
dannify merged commit 6f23665 into master Feb 29, 2020
@dannify
dannify deleted the fix-and-test-dialog-theme-switching branch February 29, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants