Dialogs and theme switching - #226
Merged
Merged
Conversation
Fixed logic in determining which theme to use // importance parent > OS > default > omitted added a mocking library so that we can change match media during tests easily
LFDanLu
previously approved these changes
Feb 26, 2020
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 69.44% 70.57% +1.13%
==========================================
Files 206 206
Lines 3973 3973
Branches 847 847
==========================================
+ Hits 2759 2804 +45
+ Misses 625 588 -37
+ Partials 589 581 -8
|
|
Build successful! 🎉 |
MidnightCoder06
approved these changes
Feb 29, 2020
dannify
approved these changes
Feb 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests so that we don't break this in the future
Fixed logic in determining which theme to use // importance parent > OS > default > omitted
added a mocking library so that we can change match media during tests easily
Closes https://jira.corp.adobe.com/browse/RSP-1527
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Team: