Skip to content

Conversation

@snowystinger
Copy link
Member

@snowystinger snowystinger commented Apr 11, 2022

Closes
Found during testing
Screen Shot 2022-04-11 at 11 39 25 AM

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@adobe-bot
Copy link

Build successful! 🎉

Copy link
Member

@ktabors ktabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove these lines?

.spectrum-Dialog--fullscreen,
.spectrum-Dialog--fullscreenTakeover {
&.spectrum-Dialog .spectrum-Dialog-grid {
display: grid;
grid-template-columns: var(--spectrum-dialog-padding-x) 1fr var(--spectrum-dialog-padding-x);
grid-template-rows: var(--spectrum-dialog-padding-y) auto auto auto 1fr auto var(--spectrum-dialog-padding-y);
grid-template-areas:
". . ."
". heading ."
". header ."
". divider ."
". content ."
". buttonGroup ."
". . .";
}
.spectrum-Dialog-heading {
&.spectrum-Dialog-heading--noHeader,
&.spectrum-Dialog-heading--noTypeIcon {
grid-area: heading;
}
/* there will never be a typeIcon here */
&.spectrum-Dialog-heading--noHeader.spectrum-Dialog-heading--noTypeIcon {
grid-area: heading;
}
}
.spectrum-Dialog-header {
&.spectrum-Dialog-header--noTypeIcon {
grid-area: header;
}
}
.spectrum-Dialog-buttonGroup {
padding-block-start: var(--spectrum-global-dimension-static-size-500);
}
.spectrum-Dialog-heading {
font-size: var(--spectrum-dialog-title-text-size);
}
}

They exist for 400% which your media query satisfies, but they might be useful for edge cases like a tall skinny browser inside a desktop application like photoshop.

@snowystinger
Copy link
Member Author

I think they should stay, it's really about the limited width, mine just makes sure the height one doesn't override the width one

@snowystinger snowystinger added the small review Easy to review PR label Apr 12, 2022
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snowystinger snowystinger merged commit ad9fc6c into main Apr 12, 2022
@snowystinger snowystinger deleted the fix-dialog-grid-iphones branch April 12, 2022 17:56
@dannify dannify added release and removed needs testing small review Easy to review PR labels Apr 28, 2022
@dannify dannify removed the release label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants