Skip to content

Fix Dialog grid iphone #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Fix Dialog grid iphone #3023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 47 additions & 1 deletion packages/@adobe/spectrum-css-temp/components/dialog/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ governing permissions and limitations under the License.
}
}

/* additional a11y support by moveing scrolling from content to dialog */
/* additional a11y support by moving scrolling from content to dialog */
@media screen and (max-height: 400px) {
.spectrum-Dialog .spectrum-Dialog-grid {
border-top-left-radius: var(--spectrum-dialog-border-radius);
Expand All @@ -453,18 +453,21 @@ governing permissions and limitations under the License.
". buttonGroup buttonGroup buttonGroup buttonGroup ."
". . . . . .";
}

.spectrum-Dialog-heading {
&.spectrum-Dialog-heading--noHeader {
grid-area: heading;
padding-inline-end: 0;
}

/* match specificity from above where it had noHeader, but here header won't prevent heading from expanding */

&.spectrum-Dialog-heading--noTypeIcon.spectrum-Dialog-heading--noTypeIcon {
grid-area: heading-start / heading-start / typeIcon-end / typeIcon-end;
padding-inline-end: 0;
}
}

.spectrum-Dialog-header {
&.spectrum-Dialog-header--noTypeIcon {
grid-area: header;
Expand All @@ -482,3 +485,46 @@ governing permissions and limitations under the License.
padding-block-start: calc(var(--spectrum-global-dimension-size-25) * 2);
}
}
@media screen and (max-height: 400px) and (max-width: 700px) {
.spectrum-Dialog--fullscreen,
.spectrum-Dialog--fullscreenTakeover {

&.spectrum-Dialog .spectrum-Dialog-grid {
display: grid;
grid-template-columns: var(--spectrum-dialog-padding-x) 1fr var(--spectrum-dialog-padding-x);
grid-template-rows: var(--spectrum-dialog-padding-y) auto auto auto 1fr auto var(--spectrum-dialog-padding-y);
grid-template-areas:
". . ."
". heading ."
". header ."
". divider ."
". content ."
". buttonGroup ."
". . .";
}
.spectrum-Dialog-heading {
&.spectrum-Dialog-heading--noHeader,
&.spectrum-Dialog-heading--noTypeIcon {
grid-area: heading;
}

/* there will never be a typeIcon here */
&.spectrum-Dialog-heading--noHeader.spectrum-Dialog-heading--noTypeIcon {
grid-area: heading;
}
}
.spectrum-Dialog-header {
&.spectrum-Dialog-header--noTypeIcon {
grid-area: header;
}
}

.spectrum-Dialog-buttonGroup {
padding-block-start: var(--spectrum-global-dimension-static-size-500);
}

.spectrum-Dialog-heading {
font-size: var(--spectrum-dialog-title-text-size);
}
}
}