Skip to content

Do not select disabled items #3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snowystinger wants to merge 4 commits into from
Closed

Do not select disabled items #3126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf7006b
Do not select disabled items
snowystinger May 13, 2022
ffa9b41
break out drag and drop tests, add test
snowystinger May 16, 2022
f96a647
fix lint
snowystinger May 16, 2022
787e3f5
Merge branch 'main' into do-not-select-disabled-items
LFDanLu May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/@react-spectrum/list/stories/ListView.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,8 @@ export function DragIntoItemExample() {
);
}

export function DragBetweenListsExample() {
export function DragBetweenListsExample(props) {
let {list1Props, list2Props} = props;
let onDropAction = action('onDrop');

let list1 = useListData({
Expand Down Expand Up @@ -832,6 +833,7 @@ export function DragBetweenListsExample() {
<Flex direction="column" margin="size-100">
<Text alignSelf="center">List 1</Text>
<ListView
{...list1Props}
aria-label="First list view"
selectionMode="multiple"
width="300px"
Expand All @@ -849,6 +851,7 @@ export function DragBetweenListsExample() {
<Flex direction="column" margin="size-100">
<Text alignSelf="center">List 2</Text>
<ListView
{...list2Props}
aria-label="Second list view"
selectionMode="multiple"
width="300px"
Expand Down
Loading