Closed
Conversation
|
Build successful! 🎉 |
LFDanLu
reviewed
May 16, 2022
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
Tested locally and confirmed that onSelectionChange doesn't fire for disabled rows now (e.g. highlight selection ListView fired onSelectionChange when keyboard navigating to a disabled row). Mind writing a test for TableView + ListView to cover that case?
snowystinger
commented
May 16, 2022
| }); | ||
| }); | ||
|
|
||
| describe('drag and drop', function () { |
Member
Author
There was a problem hiding this comment.
Removed drag and drop into its own file so this file wouldn't end up like TableView's tests
| }); | ||
|
|
||
|
|
||
| it('should not select disabled items', async function () { |
Member
Author
There was a problem hiding this comment.
This is the only new test I added
|
Build successful! 🎉 |
LFDanLu
approved these changes
May 16, 2022
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
LGTM, thanks for organizing the tests!
|
Build successful! 🎉 |
Member
Author
|
Closing as #3123 also handled it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Fixes an issue noticed in #3123 where dragging a disabled item to a new list where it was still disabled caused it to become selected.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: