Skip to content

Enhancement 1012 steplist - #5200

Closed
dgrossen wants to merge 4 commits into
adobe:steplist-componentfrom
razvanip:enhancement_1012-steplist
Closed

Enhancement 1012 steplist#5200
dgrossen wants to merge 4 commits into
adobe:steplist-componentfrom
razvanip:enhancement_1012-steplist

Conversation

@dgrossen

@dgrossen dgrossen commented Oct 4, 2023

Copy link
Copy Markdown
Collaborator

Dusting off #2832

Original PR description:

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

I took the great work @itaylor did on step list and did some of the changes that were discussed like:

  • changed aria hooks to fallow same pattern, like the rest of the components passing props state ref to get the components DOM props
  • added keyboard delegation for useStepList currently it's the same like for tabs but i will fallow with spectrum design to get the corect keyboard navigation behaviour
  • added support for useSelectableCollection in useStepList
  • moved aria-${props} out of useStepItem to StepItem to fallow the same pattern with the rest of the components

My Plan:

  • revisit styling and make sure we are aligned with UX
  • address some comments from @snowystinger regarding flex
  • add docs
  • refactor stories and add more examples

Let me know your thoughts

@dgrossen

dgrossen commented Oct 4, 2023

Copy link
Copy Markdown
Collaborator Author

Closing. Merging directly into the branch instead and linking the PR

@dgrossen dgrossen closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant