Enhancement 1012 steplist - #5200
Closed
dgrossen wants to merge 4 commits into
Closed
Conversation
Collaborator
Author
|
Closing. Merging directly into the branch instead and linking the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dusting off #2832
Original PR description:
✅ Pull Request Checklist:
I took the great work @itaylor did on step list and did some of the changes that were discussed like:
ariahooks to fallow samepattern, like the rest of the components passingpropsstaterefto get the componentsDOMpropskeyboarddelegation foruseStepListcurrently it's the same like fortabsbut i will fallow withspectrumdesign to get the corectkeyboardnavigation behaviouruseSelectableCollectioninuseStepListaria-${props}out ofuseStepItemtoStepItemto fallow the same pattern with the rest of the componentsMy Plan:
stylingand make sure we are aligned withUXflexstoriesand add more examplesLet me know your thoughts