Skip to content

fix: Make long content in quiet Picker properly truncate when in fixed width container #5813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LFDanLu merged 4 commits into from
Feb 9, 2024
Merged

fix: Make long content in quiet Picker properly truncate when in fixed width container #5813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71e08a2
fix: long picker options truncated in quiet mode
Feb 6, 2024
0940b7b
Merge branch 'main' into handle-quiet-picker-overflow
snowystinger Feb 6, 2024
41a8e81
Merge branch 'main' into handle-quiet-picker-overflow
snowystinger Feb 6, 2024
0b6ad69
Merge branch 'main' into handle-quiet-picker-overflow
LFDanLu Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/@adobe/spectrum-css-temp/components/dropdown/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,16 @@ governing permissions and limitations under the License.
.spectrum-Field.spectrum-Dropdown-fieldWrapper--quiet {
display: inline-flex;
flex-direction: column;
inline-size: auto;
inline-size: 100%;
max-width: max-content;

.spectrum-Dropdown--quiet {
inline-size: auto;
min-inline-size: var(--spectrum-dropdown-quiet-min-width);

.spectrum-Dropdown-trigger {
inline-size: auto;
inline-size: 100%;
max-width: max-content;
}
}

Expand Down
30 changes: 30 additions & 0 deletions packages/@react-spectrum/picker/stories/Picker.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,36 @@ export const Quiet: PickerStory = {
<Item key="always">Always</Item>
</Picker>
</View>
<hr />
<View
width={200}>
<h4>Quiet picker with label and fixed width (200px)</h4>
<Picker
isQuiet
label="Choose frequency"
defaultSelectedKey="sometimes">
<Item key="rarely">Rarely</Item>
<Item key="sometimes">
This text is very long and will overflow the container
</Item>
<Item key="always">Always</Item>
</Picker>
</View>
<hr />
<View
width={600}>
<h4>Quiet picker with label and fixed width (600px)</h4>
<Picker
isQuiet
label="Choose frequency"
defaultSelectedKey="sometimes">
<Item key="rarely">Rarely</Item>
<Item key="sometimes">
This text is very long the picker should expand to fit
</Item>
<Item key="always">Always</Item>
</Picker>
</View>
</View>
)
};
Expand Down