Skip to content

fix: ensure text truncates in s2 toggle button - #7322

Merged
yihuiliao merged 3 commits into
mainfrom
truncate-s2-toggle-button
Nov 6, 2024
Merged

fix: ensure text truncates in s2 toggle button#7322
yihuiliao merged 3 commits into
mainfrom
truncate-s2-toggle-button

Conversation

@yihuiliao

Copy link
Copy Markdown
Member

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot

rspbot commented Nov 5, 2024

Copy link
Copy Markdown

Comment thread packages/@react-spectrum/s2/stories/ToggleButton.stories.tsx Outdated
@rspbot

rspbot commented Nov 5, 2024

Copy link
Copy Markdown

reidbarber
reidbarber previously approved these changes Nov 5, 2024

@snowystinger snowystinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the extra logic in the story since it is docs and cover this test in chromatic

@rspbot

rspbot commented Nov 5, 2024

Copy link
Copy Markdown

@yihuiliao
yihuiliao added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 84e0437 Nov 6, 2024
@yihuiliao
yihuiliao deleted the truncate-s2-toggle-button branch November 6, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants