chore: change peer dep for S2 to be React 19 only #9211
Merged
+13
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFDanLu
commented
Nov 18, 2025
Comment on lines
+26
to
29
| } else if (dependency.workspace.ident === '@react-spectrum/s2' || dependency.workspace.ident === '@react-spectrum/s2-icon-builder') { | ||
| dependency.update('^19.0.0-rc.1'); | ||
| } else if (dependency.workspace.ident === '@react-spectrum/codemods') { | ||
| dependency.update('^18.0.0 || ^19.0.0-rc.1'); |
Member
Author
There was a problem hiding this comment.
I think this is correct since the codemods also include v3 specific monopackage codemods?
|
Build successful! 🎉 |
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
also update in verdaccio build icon builder script
|
Build successful! 🎉 |
snowystinger
approved these changes
Nov 19, 2025
reidbarber
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP