Skip to content

#215 code-review: lead description with Use-this-when trigger - #250

Merged
trieloff merged 2 commits into
mainfrom
trieloff/skill-desc-code-review
Jul 6, 2026
Merged

#215 code-review: lead description with Use-this-when trigger#250
trieloff merged 2 commits into
mainfrom
trieloff/skill-desc-code-review

Conversation

@trieloff

@trieloff trieloff commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Addresses #215.

Problemcode-review's trigger was the second sentence rather than the opening line, weakening routing.

Solution — Rewrote the description so the Use this when … trigger is the first sentence, following the recommended Use this when <trigger>. Covers <topics>. pattern. Content-only change to the frontmatter description.

Validated with npm run validate. Generated with AI assistance.


Pull Request opened by Augment Code | View session

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Tessl Plugin Lint

⚠️ edge-delivery-services — 1 warning(s)
⚠ Skill 'code-review': SKILL.md is approximately 10352 tokens (recommended maximum: 5000). Consider moving detailed content to separate reference files.

✔ Plugin adobe/aem-edge-delivery-services@0.1.0 is valid

✅ All 1 plugin(s) lint passed with 1 warning(s) total.

Updated by tessl-lint for commit 6a9f90b.

@trieloff trieloff added the ai-generated Pull request contains code generated or co-authored by AI tools label Jul 6, 2026
@trieloff
trieloff marked this pull request as ready for review July 6, 2026 18:05
@trieloff
trieloff requested a review from shsteimer as a code owner July 6, 2026 18:05
Copilot AI review requested due to automatic review settings July 6, 2026 18:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the code-review skill’s frontmatter description so routing is stronger by leading with a clear “Use this when …” trigger, aligning with the trigger-first description guidance referenced in #215.

Changes:

  • Rewrote the code-review SKILL.md frontmatter description to start with “Use this when…”
  • Kept the change content-only (description text), consistent with the PR intent

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

---
name: code-review
description: Review code for AEM Edge Delivery Services projects. Use at the end of development (before PR) for self-review, or to review pull requests. Validates code quality, performance, accessibility, and adherence to EDS best practices.
description: "Use this when reviewing AEM Edge Delivery Services code, either self-review at the end of development before opening a PR, or reviewing an existing pull request. Covers validating code quality, performance, accessibility, and adherence to EDS best practices."
@trieloff
trieloff merged commit 7002a8d into main Jul 6, 2026
9 checks passed
@trieloff
trieloff deleted the trieloff/skill-desc-code-review branch July 6, 2026 18:13
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request contains code generated or co-authored by AI tools released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants