chore: enforce curly braces and remove deprecated eslint-env comments#1521
Merged
solaris007 merged 3 commits intomainfrom Apr 8, 2026
Merged
chore: enforce curly braces and remove deprecated eslint-env comments#1521solaris007 merged 3 commits intomainfrom
solaris007 merged 3 commits intomainfrom
Conversation
eslint-config-helix 3.0.24 enables the curly rule (restrict curl to all). Expand all single-line if/while/for bodies to multi-line with braces. Remove redundant /* eslint-env mocha */ comments (globals already configured by the helix eslint test preset; comments will error in ESLint v10).
solaris007
changed the title
Multi-line curly brace expansion exposed pre-existing untested defensive branches (null guards, hint logging). Add c8 ignore comments to maintain 100% line coverage threshold.
|
This PR will trigger a patch release when merged. |
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curlyrule introduced by@adobe/eslint-config-helix3.0.24 - expand all single-lineif/while/forbodies to multi-line with braces/* eslint-env mocha */comments from 242 test files (globals already configured by the helix eslint test preset; these comments will become errors in ESLint v10)eslint-disable-next-line no-undefcomments inhtml-analyzer/src/utils.jsthat broke after curly expansion@adobe/eslint-config-helix3.0.23 -> 3.0.24 and@adobe/fetch4.2.3 -> 4.3.0 (from renovate PR fix(deps): update adobe fixes #1503)Test plan
npm run lintpasses (only pre-existingno-undefin html-analyzer now fixed)npm testpasses across all 22 packages