Skip to content

fix(LLMO-5751): clear LAST_MOD_MISSING status on redeploy, like STALE - #1848

Merged
dhavkuma merged 1 commit into
mainfrom
feat/LLMO-5751-stale-status-clear-on-redeploy
Jul 29, 2026
Merged

fix(LLMO-5751): clear LAST_MOD_MISSING status on redeploy, like STALE#1848
dhavkuma merged 1 commit into
mainfrom
feat/LLMO-5751-stale-status-clear-on-redeploy

Conversation

@dhavkuma

Copy link
Copy Markdown
Contributor

Summary

  • edgeOptimizeStatus: STALE is cleared on the next successful redeploy in #deployPerUrlSuggestions, but LAST_MOD_MISSING was not — leaving those suggestions permanently excluded from optimization even after a fresh deploy.
  • Extend the existing clear-on-redeploy logic to also cover LAST_MOD_MISSING, via a statusesToExcludeFromOptimization list.

Test plan

  • npm test -w packages/spacecat-shared-tokowaka-client — 973 passing, 100% coverage
  • npm run lint -w packages/spacecat-shared-tokowaka-client — clean
  • Added unit test mirroring the existing STALE-clearing test for LAST_MOD_MISSING

🤖 Generated with Claude Code

edgeOptimizeStatus: LAST_MOD_MISSING suggestions were never cleared on
successful redeployment, unlike STALE ones, leaving them permanently
excluded from optimization even after a fresh deploy.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@dhavkuma
dhavkuma requested a review from MysticatBot July 29, 2026 05:26

@MysticatBot MysticatBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dhavkuma,

⚠ Degraded review - no spec document was found for this change (searched the PR links, the touched repos' docs, the architecture/guidelines docs, and linked Jira). This review covers code-level quality but could not validate the change against an agreed design, so confidence is reduced. Add a spec link (PR template section 4) and re-request review for a full-confidence pass.

Verdict: Approve - clean bug fix, no blocking concerns.
Complexity: TRIVIAL - 2-line production change, single package.
Changes: extends the clear-on-redeploy logic for edgeOptimizeStatus to also cover LAST_MOD_MISSING alongside STALE (2 files).

Non-blocking (1): minor issues and suggestions
  • suggestion: hoist statusesToExcludeFromOptimization above the .map() callback so it is not re-allocated per iteration, and consider a name like statusesClearedOnRedeploy which better describes the intent - packages/spacecat-shared-tokowaka-client/src/index.js:1486

Skill: pr-review | Model: us.anthropic.claude-opus-4-6-v1[1m] | Duration: 6m 33s | Cost: $2.05 | Commit: 02b30dbc2b4481776f4e56591c14094d219429d1
If this code review was useful, please react with 👍. Otherwise, react with 👎.

@MysticatBot MysticatBot added ai-reviewed Reviewed by AI complexity:trivial AI-assessed PR complexity: TRIVIAL labels Jul 29, 2026
@dhavkuma
dhavkuma merged commit 86f199c into main Jul 29, 2026
6 checks passed
@dhavkuma
dhavkuma deleted the feat/LLMO-5751-stale-status-clear-on-redeploy branch July 29, 2026 05:50
solaris007 pushed a commit that referenced this pull request Jul 29, 2026
## [@adobe/spacecat-shared-tokowaka-client-v1.23.1](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-tokowaka-client-v1.23.0...@adobe/spacecat-shared-tokowaka-client-v1.23.1) (2026-07-29)

### Bug Fixes

* **LLMO-5751:** clear LAST_MOD_MISSING status on redeploy, like STALE ([#1848](#1848)) ([86f199c](86f199c))
@solaris007

Copy link
Copy Markdown
Member

🎉 This PR is included in version @adobe/spacecat-shared-tokowaka-client-v1.23.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhavkuma added a commit to adobe/spacecat-api-service that referenced this pull request Jul 29, 2026
## Summary
- Bumps \`@adobe/spacecat-shared-tokowaka-client\` from \`1.21.1\` →
\`1.23.0\`
- Picks up
[adobe/spacecat-shared#1848](adobe/spacecat-shared#1848):
clear \`LAST_MOD_MISSING\` \`edgeOptimizeStatus\` on redeploy, matching
the existing \`STALE\`-clearing behaviour in
\`#deployPerUrlSuggestions\`

## Test plan
- [ ] CI passes
- [ ] No functional changes in this repo — pure dependency bump

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-reviewed Reviewed by AI complexity:trivial AI-assessed PR complexity: TRIVIAL released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants