Skip to content

fix: actionButton focus-ring active state visual issue #755 - #777

Merged
bernhard-adobe merged 1 commit into
mainfrom
fix-actionbutton-focus-ring-active-state
Jul 30, 2020
Merged

fix: actionButton focus-ring active state visual issue #755#777
bernhard-adobe merged 1 commit into
mainfrom
fix-actionbutton-focus-ring-active-state

Conversation

@bernhard-adobe

Copy link
Copy Markdown
Contributor

Original PR from @Martskin . Thank you very much for your contribution.
I am re-creating this PR so we can have the Visual Regression Testing handled by Jenkins (like for #77). Unfortunately we don't don't support that yet on forks.

Original description from #759:
This PR fixes ActionButton Focus-ring Active state visual issue #755

Description

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

image

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@bernhard-adobe bernhard-adobe added bug Results from a bug in the CSS implementation Component: Action Button labels Jul 29, 2020
@bernhard-adobe
bernhard-adobe requested a review from GarthDB July 29, 2020 22:00
@adobe-spectrum-bot

Copy link
Copy Markdown
Collaborator

VRT successfully! 🎊

View the VRT result

@bernhard-adobe
bernhard-adobe merged commit 64af508 into main Jul 30, 2020
@bernhard-adobe
bernhard-adobe deleted the fix-actionbutton-focus-ring-active-state branch July 31, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Results from a bug in the CSS implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants